All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Govindraj.R" <govindraj.raja@ti.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH] OMAP2+: Fix Compilation error on current mainline
Date: Tue, 8 Nov 2011 11:46:57 +0100	[thread overview]
Message-ID: <4EB908A1.40404@ti.com> (raw)
In-Reply-To: <1320733698-23411-1-git-send-email-govindraj.raja@ti.com>

Hi Govind,

On 11/8/2011 7:28 AM, Govindraj.R wrote:
> Patch to fix below compilation error on latest mainline commit
> b32fc0a0629bf5894b35f33554c118aacfd0d1e2 with omap2plus_defconfig.
>
> arch/arm/mach-omap2/omap_l3_noc.c:250: error: 'THIS_MODULE' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/omap_l3_noc.o] Error 1
>
> Signed-off-by: Govindraj.R<govindraj.raja@ti.com>
> ---
>   arch/arm/mach-omap2/omap_l3_noc.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_noc.c b/arch/arm/mach-omap2/omap_l3_noc.c
> index c8b1bef..c2cc196 100644
> --- a/arch/arm/mach-omap2/omap_l3_noc.c
> +++ b/arch/arm/mach-omap2/omap_l3_noc.c
> @@ -26,6 +26,7 @@
>   #include<linux/interrupt.h>
>   #include<linux/kernel.h>
>   #include<linux/slab.h>
> +#include<linux/module.h>

That one is already fixed by Axel Lin, and already pulled by Tony.

http://www.spinics.net/lists/linux-omap/msg59847.html

This is the missing semi-colon that still need to be fixed.

Regards,
Benoit

  parent reply	other threads:[~2011-11-08 10:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 12:38 [PATCH] OMAP2+: Fix Compilation break on current mainline Govindraj.R
2011-11-07 12:59 ` Shilimkar, Santosh
2011-11-07 14:02   ` Cousson, Benoit
2011-11-08  6:28     ` [PATCH] OMAP2+: Fix Compilation error " Govindraj.R
2011-11-08  6:33       ` Shilimkar, Santosh
2011-11-08 10:46       ` Cousson, Benoit [this message]
2011-11-08 10:54         ` Santosh Shilimkar
2011-11-08 11:59           ` Govindraj
2011-11-08 15:25             ` Cousson, Benoit
2011-11-09 12:18               ` Govindraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB908A1.40404@ti.com \
    --to=b-cousson@ti.com \
    --cc=govindraj.raja@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.