All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Govindraj <govindraj.ti@gmail.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
	"Govindraj.R" <govindraj.raja@ti.com>,
	linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] OMAP2+: Fix Compilation error on current mainline
Date: Tue, 8 Nov 2011 16:25:34 +0100	[thread overview]
Message-ID: <4EB949EE.7030109@ti.com> (raw)
In-Reply-To: <CAAL8m4w4Zr-P4ywOYwZ7VwOtTNp5Yz=Zsw0y_SrkcY4yN6n49A@mail.gmail.com>

On 11/8/2011 12:59 PM, Govindraj wrote:
> On Tue, Nov 8, 2011 at 4:24 PM, Santosh Shilimkar
> <santosh.shilimkar@ti.com>  wrote:

[...]

>> Opps. I missed that one while acking the patch.
>> Indeed the semi-colon one was agreed to be the left over
>> in the last patch discussion.
>
> Sorry, my bad sent the wrong patch here's the right one.[1]
>
> --
> Thanks,
> Govindraj.R
>
> [1]:
>
>  From 9d244c0dea4de10ab9052fc1fe7bde8846ad389e Mon Sep 17 00:00:00 2001
> From: Govindraj.R<govindraj.raja@ti.com>
> Date: Tue, 8 Nov 2011 16:57:22 +0530
> Subject: [PATCH] OMAP2+: Fix Compilation error on current mainline
>
> Fix below compilation failure on mainline kernel commit id
> 1ea6b8f48918282bdca0b32a34095504ee65bab5
>
> arch/arm/mach-omap2/omap_l3_noc.c:240: error: expected ',' or ';'
> before 'MODULE_DEVICE_TABLE'

The issue is that 3.2-rc1 does not have that build error anymore...
It should appear only with this driver built as a module, and that's not 
possible yet for the l3_noc.

The fix is still good to have, but the changelog should probably be updated.

Regards,
Benoit

  reply	other threads:[~2011-11-08 15:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 12:38 [PATCH] OMAP2+: Fix Compilation break on current mainline Govindraj.R
2011-11-07 12:59 ` Shilimkar, Santosh
2011-11-07 14:02   ` Cousson, Benoit
2011-11-08  6:28     ` [PATCH] OMAP2+: Fix Compilation error " Govindraj.R
2011-11-08  6:33       ` Shilimkar, Santosh
2011-11-08 10:46       ` Cousson, Benoit
2011-11-08 10:54         ` Santosh Shilimkar
2011-11-08 11:59           ` Govindraj
2011-11-08 15:25             ` Cousson, Benoit [this message]
2011-11-09 12:18               ` Govindraj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB949EE.7030109@ti.com \
    --to=b-cousson@ti.com \
    --cc=govindraj.raja@ti.com \
    --cc=govindraj.ti@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.