From: Kevin Wolf <kwolf@redhat.com>
To: 陳韋任 <chenwj@iis.sinica.edu.tw>
Cc: qemu-trivial@nongnu.org, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] ui/vnc: Convert sasl.mechlist to g_malloc() & friends
Date: Tue, 08 Nov 2011 15:44:45 +0100 [thread overview]
Message-ID: <4EB9405D.60008@redhat.com> (raw)
In-Reply-To: <20111108143435.GA51305@cs.nctu.edu.tw>
Am 08.11.2011 15:34, schrieb 陳韋任:
>> Stefan Hajnoczi <stefanha@gmail.com> writes:
>>
>>> On Tue, Nov 8, 2011 at 12:45 PM, Markus Armbruster <armbru@redhat.com> wrote:
>>>> Fixes protocol_client_auth_sasl_mechname() not to crash when malloc()
>>>> fails. Spotted by Coverity.
>>>> ---
>>>> ui/vnc-auth-sasl.c | 19 +++++--------------
>>>> 1 files changed, 5 insertions(+), 14 deletions(-)
>>>
>>> Looks good, please add Signed-off-by.
>>
>> Gaa, too trivial to get it right in less than three tries! There must a
>> curse of brainlessness on this one...
>
> `git-format-patch -s` will generate the sign-off-by.
And git commit -s will make sure that it doesn't disappear in v2 when it
was there in v1.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: 陳韋任 <chenwj@iis.sinica.edu.tw>
Cc: qemu-trivial@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] ui/vnc: Convert sasl.mechlist to g_malloc() & friends
Date: Tue, 08 Nov 2011 15:44:45 +0100 [thread overview]
Message-ID: <4EB9405D.60008@redhat.com> (raw)
In-Reply-To: <20111108143435.GA51305@cs.nctu.edu.tw>
Am 08.11.2011 15:34, schrieb 陳韋任:
>> Stefan Hajnoczi <stefanha@gmail.com> writes:
>>
>>> On Tue, Nov 8, 2011 at 12:45 PM, Markus Armbruster <armbru@redhat.com> wrote:
>>>> Fixes protocol_client_auth_sasl_mechname() not to crash when malloc()
>>>> fails. Spotted by Coverity.
>>>> ---
>>>> ui/vnc-auth-sasl.c | 19 +++++--------------
>>>> 1 files changed, 5 insertions(+), 14 deletions(-)
>>>
>>> Looks good, please add Signed-off-by.
>>
>> Gaa, too trivial to get it right in less than three tries! There must a
>> curse of brainlessness on this one...
>
> `git-format-patch -s` will generate the sign-off-by.
And git commit -s will make sure that it doesn't disappear in v2 when it
was there in v1.
Kevin
next prev parent reply other threads:[~2011-11-08 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 12:45 [Qemu-trivial] [PATCH v2] ui/vnc: Convert sasl.mechlist to g_malloc() & friends Markus Armbruster
2011-11-08 12:45 ` [Qemu-devel] " Markus Armbruster
2011-11-08 13:14 ` [Qemu-trivial] " Stefan Hajnoczi
2011-11-08 13:14 ` [Qemu-devel] " Stefan Hajnoczi
2011-11-08 14:25 ` Markus Armbruster
2011-11-08 14:25 ` [Qemu-devel] " Markus Armbruster
2011-11-08 14:34 ` [Qemu-trivial] [Qemu-devel] " 陳韋任
2011-11-08 14:34 ` [Qemu-devel] [Qemu-trivial] " 陳韋任
2011-11-08 14:44 ` Kevin Wolf [this message]
2011-11-08 14:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB9405D.60008@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=chenwj@iis.sinica.edu.tw \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.