From: Stephen Boyd <sboyd@codeaurora.org>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: David Brown <davidb@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv3 2/2] msm: Support DEBUG_LL on MSM8660 and MSM8960
Date: Tue, 08 Nov 2011 11:14:11 -0800 [thread overview]
Message-ID: <4EB97F83.3070509@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1111081406220.3307@xanadu.home>
On 11/08/11 11:08, Nicolas Pitre wrote:
> Independently from this patch, I was wondering about this code:
>
>> + .macro senduart, rd, rx
>> +#ifdef CONFIG_MSM_HAS_DEBUG_UART_HS
>> + @ Write the 1 character to UARTDM_TF
>> + str \rd, [\rx, #0x70]
>> +#else
>> teq \rx, #0
>> strne \rd, [\rx, #0x0C]
>> +#endif
>> .endm
> Why testing for zero in the #else part? The upper level code should
> never call this macro with a null byte.
>
I was wondering the same thing, I don't know why that test for null is
there. I will dust off the old 7201a (literally) and see what I can find
out. It certainly looks unnecessary.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/2] msm: Support DEBUG_LL on MSM8660 and MSM8960
Date: Tue, 08 Nov 2011 11:14:11 -0800 [thread overview]
Message-ID: <4EB97F83.3070509@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1111081406220.3307@xanadu.home>
On 11/08/11 11:08, Nicolas Pitre wrote:
> Independently from this patch, I was wondering about this code:
>
>> + .macro senduart, rd, rx
>> +#ifdef CONFIG_MSM_HAS_DEBUG_UART_HS
>> + @ Write the 1 character to UARTDM_TF
>> + str \rd, [\rx, #0x70]
>> +#else
>> teq \rx, #0
>> strne \rd, [\rx, #0x0C]
>> +#endif
>> .endm
> Why testing for zero in the #else part? The upper level code should
> never call this macro with a null byte.
>
I was wondering the same thing, I don't know why that test for null is
there. I will dust off the old 7201a (literally) and see what I can find
out. It certainly looks unnecessary.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-11-08 19:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 18:33 [PATCHv3 0/2] MSM8660/8960 DEBUG_LL support and cleanups Stephen Boyd
2011-11-08 18:33 ` Stephen Boyd
2011-11-08 18:33 ` [PATCHv3 1/2] ARM: msm: Consolidate and move DEBUG_LL to DEBUG_LL choice Stephen Boyd
2011-11-08 18:33 ` Stephen Boyd
2011-11-08 18:33 ` [PATCHv3 2/2] msm: Support DEBUG_LL on MSM8660 and MSM8960 Stephen Boyd
2011-11-08 18:33 ` Stephen Boyd
2011-11-08 19:08 ` Nicolas Pitre
2011-11-08 19:08 ` Nicolas Pitre
2011-11-08 19:14 ` Stephen Boyd [this message]
2011-11-08 19:14 ` Stephen Boyd
2011-11-08 19:59 ` David Brown
2011-11-08 19:59 ` David Brown
2011-11-08 20:22 ` Nicolas Pitre
2011-11-08 20:22 ` Nicolas Pitre
2011-11-09 4:11 ` Stephen Boyd
2011-11-09 4:11 ` Stephen Boyd
2011-12-05 18:27 ` [PATCHv3 3/2] ARM: msm: Drop useless teq from DEBUG_LL support Stephen Boyd
2011-12-05 18:27 ` Stephen Boyd
2011-12-05 18:40 ` Nicolas Pitre
2011-12-05 18:40 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB97F83.3070509@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.