From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm, davinci_emac: fixup
Date: Wed, 09 Nov 2011 07:56:55 +0100 [thread overview]
Message-ID: <4EBA2437.30807@denx.de> (raw)
In-Reply-To: <20111109065119.BB539189301F@gemini.denx.de>
Hello Wolfgang,
Wolfgang Denk wrote:
> Dear Heiko Schocher,
>
> In message <1320819979-3861-1-git-send-email-hs@denx.de> you wrote:
> ...
>> + if (count < MAX_PHY)
>> + active_phy_addr[j++] = i;
>> + else {
>> + printf("%s: to much PHYs detected.\n",
>> + __func__);
>> + break;
>> + }
>
> Coding Style: if the "else" branch uses braces, the "if" branch shall
> use braces, too.
Hups, you are right, just checked only with checkpatch ... sorry.
Changed!
> Also, please s/too much/too many/ in the printf() above.
Done.
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-11-09 6:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 6:26 [U-Boot] [PATCH] arm, davinci_emac: fixup Heiko Schocher
2011-11-09 6:51 ` Wolfgang Denk
2011-11-09 6:56 ` Heiko Schocher [this message]
2011-11-09 11:39 ` Prabhakar Lad
2011-11-09 12:26 ` Heiko Schocher
2011-11-09 12:38 ` Prabhakar Lad
2011-11-09 12:45 ` Heiko Schocher
2011-11-09 13:04 ` [U-Boot] [PATCH v2] " Heiko Schocher
2011-11-09 16:23 ` Mike Frysinger
2011-11-09 16:50 ` [U-Boot] [PATCH v3] arm, davinci_emac: fix driver bug if more then 3 PHYs are detected Heiko Schocher
2011-11-09 17:05 ` Tom Rini
2011-11-10 4:43 ` Heiko Schocher
2011-11-10 5:04 ` Tom Rini
2011-11-10 6:00 ` [U-Boot] [PATCH v4] " Heiko Schocher
2011-11-10 14:37 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBA2437.30807@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.