From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] arm, davinci_emac: fix driver bug if more then 3 PHYs are detected
Date: Thu, 10 Nov 2011 05:43:41 +0100 [thread overview]
Message-ID: <4EBB567D.7020904@denx.de> (raw)
In-Reply-To: <CA+M6bXmnQqHAr0CO7zfFMkatHovBZaVSwKyVEBZVLWvcRG2S=A@mail.gmail.com>
Hello Tom,
Tom Rini wrote:
> On Wed, Nov 9, 2011 at 9:50 AM, Heiko Schocher <hs@denx.de> wrote:
>> since commits:
>> davinci: emac: add support for more than 1 PHYs
>> 062fe7d332c28ede25626f448681e43d76bb312e
>>
>> davinci: remove obsolete macro CONFIG_EMAC_MDIO_PHY_NUM
>> fb1d6332b5430b90a8fa8ebab709f33a60e9f816
> [snip]
>> - MAX_PHY from 3 to 7
>
> Why don't we add a CONFIG here and default to 3, ie
> #ifndef CONFIG_SYS_something
> #define CONFIG_SYS_something 3
> #endif
Do we really need a config option for this? Why 3 or 7 as I did?
Shouldn't we set this define to 32, as this is the max possible
PHYs? Ok, we loose some RAM with this option ...
Would CONFIG_SYS_DAVINCI_EMAC_PHY_COUNT a good name?
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-11-10 4:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 6:26 [U-Boot] [PATCH] arm, davinci_emac: fixup Heiko Schocher
2011-11-09 6:51 ` Wolfgang Denk
2011-11-09 6:56 ` Heiko Schocher
2011-11-09 11:39 ` Prabhakar Lad
2011-11-09 12:26 ` Heiko Schocher
2011-11-09 12:38 ` Prabhakar Lad
2011-11-09 12:45 ` Heiko Schocher
2011-11-09 13:04 ` [U-Boot] [PATCH v2] " Heiko Schocher
2011-11-09 16:23 ` Mike Frysinger
2011-11-09 16:50 ` [U-Boot] [PATCH v3] arm, davinci_emac: fix driver bug if more then 3 PHYs are detected Heiko Schocher
2011-11-09 17:05 ` Tom Rini
2011-11-10 4:43 ` Heiko Schocher [this message]
2011-11-10 5:04 ` Tom Rini
2011-11-10 6:00 ` [U-Boot] [PATCH v4] " Heiko Schocher
2011-11-10 14:37 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBB567D.7020904@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.