From: Archit Taneja <a0393947@ti.com>
To: Ilya Yanok <yanok@emcraft.com>
Cc: linux-omap@vger.kernel.org, wd@denx.de, dzu@denx.de, sasha_d@emcraft.com
Subject: Re: [PATCH 1/4] AM35xx: DSS: there is no VDDS_DSI on AM35xx
Date: Wed, 9 Nov 2011 15:40:20 +0530 [thread overview]
Message-ID: <4EBA518C.6050405@ti.com> (raw)
In-Reply-To: <1320797568-11169-2-git-send-email-yanok@emcraft.com>
Hi,
On Wednesday 09 November 2011 05:42 AM, Ilya Yanok wrote:
> AM35xx don't have VDDS_DSI regulator.
AM35xx do have vdds_dsi regulator. Are you saying that your particular
board doesn't have vdds_dsi connected to a regulator?
I assumed that vdds_dsi regulator was required for DPI to function
properly on omap3 devices.
Archit
>
> Signed-off-by: Ilya Yanok<yanok@emcraft.com>
> ---
> drivers/video/omap2/dss/dpi.c | 9 +++++----
> drivers/video/omap2/dss/dsi.c | 18 ++++++++++++------
> 2 files changed, 17 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/dpi.c b/drivers/video/omap2/dss/dpi.c
> index 976ac23..929e451 100644
> --- a/drivers/video/omap2/dss/dpi.c
> +++ b/drivers/video/omap2/dss/dpi.c
> @@ -191,7 +191,7 @@ int omapdss_dpi_display_enable(struct omap_dss_device *dssdev)
> goto err_start_dev;
> }
>
> - if (cpu_is_omap34xx()) {
> + if (cpu_is_omap34xx()&& !cpu_is_omap3505()&& !cpu_is_omap3517()) {
> r = regulator_enable(dpi.vdds_dsi_reg);
> if (r)
> goto err_reg_enable;
> @@ -238,7 +238,7 @@ err_get_dsi:
> err_get_dispc:
> dss_runtime_put();
> err_get_dss:
> - if (cpu_is_omap34xx())
> + if (cpu_is_omap34xx()&& !cpu_is_omap3505()&& !cpu_is_omap3517())
> regulator_disable(dpi.vdds_dsi_reg);
> err_reg_enable:
> omap_dss_stop_device(dssdev);
> @@ -260,7 +260,7 @@ void omapdss_dpi_display_disable(struct omap_dss_device *dssdev)
> dispc_runtime_put();
> dss_runtime_put();
>
> - if (cpu_is_omap34xx())
> + if (cpu_is_omap34xx()&& !cpu_is_omap3505()&& !cpu_is_omap3517())
> regulator_disable(dpi.vdds_dsi_reg);
>
> omap_dss_stop_device(dssdev);
> @@ -348,7 +348,8 @@ int dpi_init_display(struct omap_dss_device *dssdev)
> {
> DSSDBG("init_display\n");
>
> - if (cpu_is_omap34xx()&& dpi.vdds_dsi_reg == NULL) {
> + if (cpu_is_omap34xx()&& (dpi.vdds_dsi_reg == NULL)&&
> + !cpu_is_omap3505()&& !cpu_is_omap3517()) {
> struct regulator *vdds_dsi;
>
> vdds_dsi = dss_get_vdds_dsi();
> diff --git a/drivers/video/omap2/dss/dsi.c b/drivers/video/omap2/dss/dsi.c
> index 5abf8e7..7f38ab6 100644
> --- a/drivers/video/omap2/dss/dsi.c
> +++ b/drivers/video/omap2/dss/dsi.c
> @@ -1610,7 +1610,8 @@ int dsi_pll_init(struct platform_device *dsidev, bool enable_hsclk,
>
> DSSDBG("PLL init\n");
>
> - if (dsi->vdds_dsi_reg == NULL) {
> + if ((dsi->vdds_dsi_reg == NULL)&&
> + !cpu_is_omap3517()&& !cpu_is_omap3505()) {
> struct regulator *vdds_dsi;
>
> vdds_dsi = regulator_get(&dsi->pdev->dev, "vdds_dsi");
> @@ -1629,7 +1630,8 @@ int dsi_pll_init(struct platform_device *dsidev, bool enable_hsclk,
> */
> dsi_enable_scp_clk(dsidev);
>
> - if (!dsi->vdds_dsi_enabled) {
> + if (!dsi->vdds_dsi_enabled&&
> + !cpu_is_omap3517()&& !cpu_is_omap3505()) {
> r = regulator_enable(dsi->vdds_dsi_reg);
> if (r)
> goto err0;
> @@ -1668,7 +1670,8 @@ int dsi_pll_init(struct platform_device *dsidev, bool enable_hsclk,
>
> return 0;
> err1:
> - if (dsi->vdds_dsi_enabled) {
> + if (dsi->vdds_dsi_enabled&&
> + !cpu_is_omap3517()&& !cpu_is_omap3505()) {
> regulator_disable(dsi->vdds_dsi_reg);
> dsi->vdds_dsi_enabled = false;
> }
> @@ -1684,7 +1687,8 @@ void dsi_pll_uninit(struct platform_device *dsidev, bool disconnect_lanes)
>
> dsi->pll_locked = 0;
> dsi_pll_power(dsidev, DSI_PLL_POWER_OFF);
> - if (disconnect_lanes) {
> + if (disconnect_lanes&&
> + !cpu_is_omap3517()&& !cpu_is_omap3505()) {
> WARN_ON(!dsi->vdds_dsi_enabled);
> regulator_disable(dsi->vdds_dsi_reg);
> dsi->vdds_dsi_enabled = false;
> @@ -4530,7 +4534,8 @@ int dsi_init_display(struct omap_dss_device *dssdev)
> OMAP_DSS_DISPLAY_CAP_TEAR_ELIM;
> }
>
> - if (dsi->vdds_dsi_reg == NULL) {
> + if ((dsi->vdds_dsi_reg == NULL)&&
> + !cpu_is_omap3517()&& !cpu_is_omap3505()) {
> struct regulator *vdds_dsi;
>
> vdds_dsi = regulator_get(&dsi->pdev->dev, "vdds_dsi");
> @@ -4799,7 +4804,8 @@ static int omap_dsihw_remove(struct platform_device *dsidev)
>
> dsi_put_clocks(dsidev);
>
> - if (dsi->vdds_dsi_reg != NULL) {
> + if ((dsi->vdds_dsi_reg != NULL)&&
> + !cpu_is_omap3517()&& !cpu_is_omap3505()) {
> if (dsi->vdds_dsi_enabled) {
> regulator_disable(dsi->vdds_dsi_reg);
> dsi->vdds_dsi_enabled = false;
next prev parent reply other threads:[~2011-11-09 10:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 0:12 [PATCH 0/4] Support for the HTKW mcx board Ilya Yanok
2011-11-09 0:12 ` [PATCH 1/4] AM35xx: DSS: there is no VDDS_DSI on AM35xx Ilya Yanok
2011-11-09 10:10 ` Archit Taneja [this message]
2011-11-09 18:26 ` Ilya Yanok
2011-11-10 6:42 ` Archit Taneja
2011-11-16 21:03 ` Ilya Yanok
2011-11-09 0:12 ` [PATCH 2/4] omap_dss: add FocalTech ETM070003DH6 display support Ilya Yanok
2011-11-17 0:28 ` Ilya Yanok
2011-11-17 6:52 ` Igor Grinberg
2011-11-17 6:52 ` Igor Grinberg
2011-11-17 10:26 ` Tomi Valkeinen
2011-11-20 18:12 ` Ilya Yanok
2011-11-20 18:15 ` [PATCH V2] " Ilya Yanok
2011-11-22 10:04 ` Tomi Valkeinen
2011-11-09 0:12 ` [PATCH 3/4] dts/omap3: split omap3.dtsi Ilya Yanok
2011-11-10 12:18 ` Igor Grinberg
2011-11-10 17:09 ` Cousson, Benoit
2011-11-10 17:26 ` Igor Grinberg
2011-11-10 18:07 ` Cousson, Benoit
2011-11-11 7:32 ` Igor Grinberg
2011-11-09 0:12 ` [PATCH 4/4] mcx: initial support for HTKW mcx board Ilya Yanok
2011-11-10 13:08 ` Igor Grinberg
2011-11-11 0:12 ` Tony Lindgren
2011-11-14 20:39 ` Ilya Yanok
2011-11-19 0:36 ` Tony Lindgren
2011-11-22 0:21 ` Ilya Yanok
2011-12-08 0:04 ` Tony Lindgren
2011-11-13 17:56 ` Pankaj Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBA518C.6050405@ti.com \
--to=a0393947@ti.com \
--cc=dzu@denx.de \
--cc=linux-omap@vger.kernel.org \
--cc=sasha_d@emcraft.com \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.