From: Ilya Yanok <yanok@emcraft.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, wd@denx.de, dzu@denx.de, sasha_d@emcraft.com
Subject: Re: [PATCH 2/4] omap_dss: add FocalTech ETM070003DH6 display support
Date: Sun, 20 Nov 2011 22:12:22 +0400 [thread overview]
Message-ID: <4EC94306.4060505@emcraft.com> (raw)
In-Reply-To: <1321525575.1919.78.camel@deskari>
Hi Tomi,
On 17.11.2011 14:26, Tomi Valkeinen wrote:
>> + .acbi = 0x0,
>> + .acb = 0x28,
>
> You could just remove .acbi and .acb, I don't think they are needed.
You are right.
>> + .config = OMAP_DSS_LCD_TFT | OMAP_DSS_LCD_IVS |
>> + OMAP_DSS_LCD_IHS,
>> + .power_on_delay = 50,
>> + .power_off_delay = 100,
>
> Did you check from the panel spec if any delays are needed? These look
> like just copied from the Sharp panel data.
Actually they were copied from some vendor code, but you are right
again, I can't see anything concerning the delays in the panel spec and
panel works ok with the delays thrown out.
Regards, Ilya.
next prev parent reply other threads:[~2011-11-20 18:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 0:12 [PATCH 0/4] Support for the HTKW mcx board Ilya Yanok
2011-11-09 0:12 ` [PATCH 1/4] AM35xx: DSS: there is no VDDS_DSI on AM35xx Ilya Yanok
2011-11-09 10:10 ` Archit Taneja
2011-11-09 18:26 ` Ilya Yanok
2011-11-10 6:42 ` Archit Taneja
2011-11-16 21:03 ` Ilya Yanok
2011-11-09 0:12 ` [PATCH 2/4] omap_dss: add FocalTech ETM070003DH6 display support Ilya Yanok
2011-11-17 0:28 ` Ilya Yanok
2011-11-17 6:52 ` Igor Grinberg
2011-11-17 6:52 ` Igor Grinberg
2011-11-17 10:26 ` Tomi Valkeinen
2011-11-20 18:12 ` Ilya Yanok [this message]
2011-11-20 18:15 ` [PATCH V2] " Ilya Yanok
2011-11-22 10:04 ` Tomi Valkeinen
2011-11-09 0:12 ` [PATCH 3/4] dts/omap3: split omap3.dtsi Ilya Yanok
2011-11-10 12:18 ` Igor Grinberg
2011-11-10 17:09 ` Cousson, Benoit
2011-11-10 17:26 ` Igor Grinberg
2011-11-10 18:07 ` Cousson, Benoit
2011-11-11 7:32 ` Igor Grinberg
2011-11-09 0:12 ` [PATCH 4/4] mcx: initial support for HTKW mcx board Ilya Yanok
2011-11-10 13:08 ` Igor Grinberg
2011-11-11 0:12 ` Tony Lindgren
2011-11-14 20:39 ` Ilya Yanok
2011-11-19 0:36 ` Tony Lindgren
2011-11-22 0:21 ` Ilya Yanok
2011-12-08 0:04 ` Tony Lindgren
2011-11-13 17:56 ` Pankaj Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC94306.4060505@emcraft.com \
--to=yanok@emcraft.com \
--cc=dzu@denx.de \
--cc=linux-omap@vger.kernel.org \
--cc=sasha_d@emcraft.com \
--cc=tomi.valkeinen@ti.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.