* [PATCH 4/6] spi/pl022: skip default configuration before suspending
@ 2011-11-09 10:39 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2011-11-09 10:39 UTC (permalink / raw)
To: Grant Likely, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
Cc: Viresh Kumar, Linus Walleij,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Virupax Sadashivpetimath
From: Virupax Sadashivpetimath <virupax.sadashivpetimath-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
The loading of the default configuration before suspending has
been in the driver since its inception, but it is not really
needed. Especially so since we take to all the trouble of
enabling and disabling power and clock just to do this. Let's
scrap this now.
Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/spi/spi-pl022.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index fa3eaae..bffad2a 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev)
return status;
}
- amba_vcore_enable(pl022->adev);
- amba_pclk_enable(pl022->adev);
- load_ssp_default_config(pl022);
- amba_pclk_disable(pl022->adev);
- amba_vcore_disable(pl022->adev);
- dev_dbg(dev, "suspended\n");
+ dev_dbg(&adev->dev, "suspended\n");
return 0;
}
--
1.7.3.2
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/6] spi/pl022: skip default configuration before suspending
@ 2011-11-09 10:39 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2011-11-09 10:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
The loading of the default configuration before suspending has
been in the driver since its inception, but it is not really
needed. Especially so since we take to all the trouble of
enabling and disabling power and clock just to do this. Let's
scrap this now.
Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/spi/spi-pl022.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index fa3eaae..bffad2a 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev)
return status;
}
- amba_vcore_enable(pl022->adev);
- amba_pclk_enable(pl022->adev);
- load_ssp_default_config(pl022);
- amba_pclk_disable(pl022->adev);
- amba_vcore_disable(pl022->adev);
- dev_dbg(dev, "suspended\n");
+ dev_dbg(&adev->dev, "suspended\n");
return 0;
}
--
1.7.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1320835154-31303-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>]
* Re: [PATCH 4/6] spi/pl022: skip default configuration before suspending
2011-11-09 10:39 ` Linus Walleij
@ 2011-11-09 10:55 ` Viresh Kumar
-1 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2011-11-09 10:55 UTC (permalink / raw)
To: Linus WALLEIJ
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Linus Walleij,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Virupax SADASHIVPETIMATH
On 11/9/2011 4:09 PM, Linus WALLEIJ wrote:
> From: Virupax Sadashivpetimath <virupax.sadashivpetimath-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
>
> The loading of the default configuration before suspending has
> been in the driver since its inception, but it is not really
> needed. Especially so since we take to all the trouble of
> enabling and disabling power and clock just to do this. Let's
> scrap this now.
>
> Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
> Signed-off-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> drivers/spi/spi-pl022.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index fa3eaae..bffad2a 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev)
> return status;
> }
>
> - amba_vcore_enable(pl022->adev);
> - amba_pclk_enable(pl022->adev);
> - load_ssp_default_config(pl022);
> - amba_pclk_disable(pl022->adev);
> - amba_vcore_disable(pl022->adev);
> - dev_dbg(dev, "suspended\n");
> + dev_dbg(&adev->dev, "suspended\n");
why adev->dev instead of dev?
> return 0;
> }
>
--
viresh
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/6] spi/pl022: skip default configuration before suspending
@ 2011-11-09 10:55 ` Viresh Kumar
0 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2011-11-09 10:55 UTC (permalink / raw)
To: linux-arm-kernel
On 11/9/2011 4:09 PM, Linus WALLEIJ wrote:
> From: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
>
> The loading of the default configuration before suspending has
> been in the driver since its inception, but it is not really
> needed. Especially so since we take to all the trouble of
> enabling and disabling power and clock just to do this. Let's
> scrap this now.
>
> Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/spi/spi-pl022.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index fa3eaae..bffad2a 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev)
> return status;
> }
>
> - amba_vcore_enable(pl022->adev);
> - amba_pclk_enable(pl022->adev);
> - load_ssp_default_config(pl022);
> - amba_pclk_disable(pl022->adev);
> - amba_vcore_disable(pl022->adev);
> - dev_dbg(dev, "suspended\n");
> + dev_dbg(&adev->dev, "suspended\n");
why adev->dev instead of dev?
> return 0;
> }
>
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <4EBA5C08.1040709-qxv4g6HH51o@public.gmane.org>]
* Re: [PATCH 4/6] spi/pl022: skip default configuration before suspending
2011-11-09 10:55 ` Viresh Kumar
@ 2011-11-09 12:31 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2011-11-09 12:31 UTC (permalink / raw)
To: Viresh Kumar
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Linus WALLEIJ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Virupax SADASHIVPETIMATH
On Wed, Nov 9, 2011 at 11:55 AM, Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org> wrote:
> On 11/9/2011 4:09 PM, Linus WALLEIJ wrote:
>>
>> - amba_vcore_enable(pl022->adev);
>> - amba_pclk_enable(pl022->adev);
>> - load_ssp_default_config(pl022);
>> - amba_pclk_disable(pl022->adev);
>> - amba_vcore_disable(pl022->adev);
>> - dev_dbg(dev, "suspended\n");
>> + dev_dbg(&adev->dev, "suspended\n");
>
> why adev->dev instead of dev?
Plain bug. It doesn't even compile with -DDEBUG :-/
I'll fix it up..
Linus
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/6] spi/pl022: skip default configuration before suspending
@ 2011-11-09 12:31 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2011-11-09 12:31 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 9, 2011 at 11:55 AM, Viresh Kumar <viresh.kumar@st.com> wrote:
> On 11/9/2011 4:09 PM, Linus WALLEIJ wrote:
>>
>> - ? ? amba_vcore_enable(pl022->adev);
>> - ? ? amba_pclk_enable(pl022->adev);
>> - ? ? load_ssp_default_config(pl022);
>> - ? ? amba_pclk_disable(pl022->adev);
>> - ? ? amba_vcore_disable(pl022->adev);
>> - ? ? dev_dbg(dev, "suspended\n");
>> + ? ? dev_dbg(&adev->dev, "suspended\n");
>
> why adev->dev instead of dev?
Plain bug. It doesn't even compile with -DDEBUG :-/
I'll fix it up..
Linus
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-09 12:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-09 10:39 [PATCH 4/6] spi/pl022: skip default configuration before suspending Linus Walleij
2011-11-09 10:39 ` Linus Walleij
[not found] ` <1320835154-31303-1-git-send-email-linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2011-11-09 10:55 ` Viresh Kumar
2011-11-09 10:55 ` Viresh Kumar
[not found] ` <4EBA5C08.1040709-qxv4g6HH51o@public.gmane.org>
2011-11-09 12:31 ` Linus Walleij
2011-11-09 12:31 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.