From: Stefan Weil <sw@weilnetz.de>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 1.0 v2] configure: fix detection for xattr.h on modern distributions
Date: Wed, 09 Nov 2011 19:23:40 +0100 [thread overview]
Message-ID: <4EBAC52C.2030206@weilnetz.de> (raw)
In-Reply-To: <1320834838-14623-1-git-send-email-avi@redhat.com>
Am 09.11.2011 11:33, schrieb Avi Kivity:
> Modern distributions place xattr.h in /usr/include/sys, and fold
> libattr.so into libc. They also don't have an ENOATTR.
>
> Make configure detect this, and add a qemu-xattr.h file that
> directs the #include to the right place.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>
> v2: try for libc first, libattr second
>
[...]
> +
> +/*
> + * Modern distributions (e.g. Fedora 15, have no libattr.so, place attr.h
> + * in /usr/include/sys, and don't have ENOATTR.
>
There is a ')' missing, so I add it here: :-)
Whoever commits the patch can add it, too, so no v3 is needed for this
patch.
> + */
> +
> +#include "config-host.h"
> +
> +#ifdef CONFIG_LIBATTR
> +# include<attr/xattr.h>
> +#else
> +# define ENOATTR ENODATA
> +# include<sys/xattr.h>
> +#endif
> +
> +#endif
>
prev parent reply other threads:[~2011-11-09 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 10:33 [Qemu-devel] [PATCH 1.0 v2] configure: fix detection for xattr.h on modern distributions Avi Kivity
2011-11-09 11:44 ` Aneesh Kumar K.V
2011-11-09 11:47 ` Aneesh Kumar K.V
2011-11-09 12:41 ` Avi Kivity
2011-11-09 18:23 ` Stefan Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBAC52C.2030206@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.