Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

[Anthony Liguori <anthony@codemonkey.ws>]

On 11/09/2011 05:44 PM, Alexander Graf wrote:
>
> On 10.11.2011, at 00:38, Anthony Liguori wrote:
>
>> On 11/09/2011 05:12 PM, Alexander Graf wrote:
>>>
>>>> We have been using it that way in the past and I am not aware of a patch
>>>> that removed ancient cleanups, so it's good practice to keep it working
>>>> that way.
>>>>
>>>> When I do a git pull I don't know whether or what it may bring. Always
>>>> doing make clean just-in-case is simply unproductive.
>>>
>>> I agree. After a git pull the worst case I want to see is that I need to do make defconfig clean. Anything that doesn't clean up this way leaves my build in a broken state, meaning it's a bug to me.
>>
>> Sorry, but there's no way around this.  This doesn't happen often and emails are almost always sent ahead of time.
>>
>> It's impossible to test something like this because by definition, the code no longer lives in the tree.
>
> If we don't want to fix it, then we should remove the object directories for the build targets on git updates.

I suspect the real problem you're having is that you are building within the src 
directory instead of a separate object directory.

But at any rate, if you do a 'make clean' before a git fetch/merge, you'll also 
be fine.

Regards,

Anthony Liguori

>
>
> Alex
>
>