From: Bryan Huntsman <bryanh@codeaurora.org>
To: Harini Jayaraman <harinij@codeaurora.org>
Cc: grant.likely@secretlab.ca, davidb@codeaurora.org,
kheitke@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: QUP based bus driver for Qualcomm MSM chipsets
Date: Wed, 09 Nov 2011 17:34:46 -0800 [thread overview]
Message-ID: <4EBB2A36.9040609@codeaurora.org> (raw)
In-Reply-To: <1320887221-7165-1-git-send-email-harinij@codeaurora.org>
On 11/09/2011 05:07 PM, Harini Jayaraman wrote:
> This bus driver supports the QUP SPI hardware controller in the Qualcomm
> MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general
> purpose data path engine with input/output FIFOs and an embedded SPI
> mini-core. The driver currently supports only FIFO mode.
>
> Signed-off-by: Harini Jayaraman <harinij@codeaurora.org>
> ---
> drivers/spi/Kconfig | 10 +
> drivers/spi/Makefile | 1 +
> drivers/spi/msm_spi_qsd.h | 436 +++++++++++++
> drivers/spi/spi-qsd.c | 1144 +++++++++++++++++++++++++++++++++
> include/linux/platform_data/msm_spi.h | 19 +
> 5 files changed, 1610 insertions(+), 0 deletions(-)
> create mode 100644 drivers/spi/msm_spi_qsd.h
> create mode 100644 drivers/spi/spi-qsd.c
> create mode 100644 include/linux/platform_data/msm_spi.h
A few high-level comments to start. Let's drop 'qsd' from all the
names. We haven't used that naming convention for several years now.
Better to just call this 'spi-qup.[ch]'. Also, please update the
copyright dates. This driver existed before 2011. Thanks.
- Bryan
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: bryanh@codeaurora.org (Bryan Huntsman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: QUP based bus driver for Qualcomm MSM chipsets
Date: Wed, 09 Nov 2011 17:34:46 -0800 [thread overview]
Message-ID: <4EBB2A36.9040609@codeaurora.org> (raw)
In-Reply-To: <1320887221-7165-1-git-send-email-harinij@codeaurora.org>
On 11/09/2011 05:07 PM, Harini Jayaraman wrote:
> This bus driver supports the QUP SPI hardware controller in the Qualcomm
> MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general
> purpose data path engine with input/output FIFOs and an embedded SPI
> mini-core. The driver currently supports only FIFO mode.
>
> Signed-off-by: Harini Jayaraman <harinij@codeaurora.org>
> ---
> drivers/spi/Kconfig | 10 +
> drivers/spi/Makefile | 1 +
> drivers/spi/msm_spi_qsd.h | 436 +++++++++++++
> drivers/spi/spi-qsd.c | 1144 +++++++++++++++++++++++++++++++++
> include/linux/platform_data/msm_spi.h | 19 +
> 5 files changed, 1610 insertions(+), 0 deletions(-)
> create mode 100644 drivers/spi/msm_spi_qsd.h
> create mode 100644 drivers/spi/spi-qsd.c
> create mode 100644 include/linux/platform_data/msm_spi.h
A few high-level comments to start. Let's drop 'qsd' from all the
names. We haven't used that naming convention for several years now.
Better to just call this 'spi-qup.[ch]'. Also, please update the
copyright dates. This driver existed before 2011. Thanks.
- Bryan
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-11-10 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 1:07 [PATCH] spi: QUP based bus driver for Qualcomm MSM chipsets Harini Jayaraman
2011-11-10 1:07 ` Harini Jayaraman
2011-11-10 1:34 ` Bryan Huntsman [this message]
2011-11-10 1:34 ` Bryan Huntsman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBB2A36.9040609@codeaurora.org \
--to=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=grant.likely@secretlab.ca \
--cc=harinij@codeaurora.org \
--cc=kheitke@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.