From: Deng-Cheng Zhu <dczhu@mips.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 1/4] MIPS/Perf-events: update the map of unsupported events for 74K
Date: Thu, 10 Nov 2011 18:08:42 +0800 [thread overview]
Message-ID: <4EBBA2AA.6000901@mips.com> (raw)
In-Reply-To: <20111109204020.GB13280@linux-mips.org>
On 11/10/2011 04:40 AM, Ralf Baechle wrote:
> On Mon, Oct 24, 2011 at 06:55:59PM +0800, Deng-Cheng Zhu wrote:
>
>> Update the raw event info for 74K according to the latest document.
>
>> +/*
>> + * MIPS document MD00519 (MIPS32(r) 74K(tm) Processor Core Family Software
>> + * User's Manual, Revision 01.05)
>> + */
>> #define IS_UNSUPPORTED_74K_EVENT(r, b) \
>> - ((r) == 5 || ((r)>= 135&& (r)<= 137) || \
>> - ((b)>= 10&& (b)<= 12) || (b) == 22 || (b) == 27 || \
>> - (b) == 33 || (b) == 34 || ((b)>= 47&& (b)<= 49) || \
>> - (r) == 178 || (b) == 55 || (b) == 57 || (b) == 60 || \
>> - (b) == 61 || (r) == 62 || (r) == 191 || \
>> - ((b)>= 64&& (b)<= 127))
>> + ((r) == 5 || (r) == 135 || ((b)>= 10&& (b)<= 12) || \
>> + (b) == 27 || (b) == 33 || (b) == 34 || (b) == 47 || \
>> + (b) == 48 || (r) == 178 || (r) == 187 || (b) == 60 || \
>> + (b) == 61 || (r) == 191 || (r) == 71 || (r) == 72 || \
>> + (b) == 73 || ((b)>= 77&& (b)<= 127))
>
> ...
> Afair there are MIPS licensee who have modified the counters to count
> extra events so I sense some madness in that direction.
A good point. Now that the user is working with raw events, the manual
is being used for sure. The user should have known what will be counted.
But we should keep the mappings for event cntr_mask and range. Although
they are also subject to changes by Arch licensees, patches will be
needed for their CPU in that case.
Deng-Cheng
WARNING: multiple messages have this Message-ID (diff)
From: Deng-Cheng Zhu <dczhu@mips.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 1/4] MIPS/Perf-events: update the map of unsupported events for 74K
Date: Thu, 10 Nov 2011 18:08:42 +0800 [thread overview]
Message-ID: <4EBBA2AA.6000901@mips.com> (raw)
Message-ID: <20111110100842.HsFicfrz3aDOZo4VX-T7TTTrBIMAztJTQKIZjNg80iE@z> (raw)
In-Reply-To: <20111109204020.GB13280@linux-mips.org>
On 11/10/2011 04:40 AM, Ralf Baechle wrote:
> On Mon, Oct 24, 2011 at 06:55:59PM +0800, Deng-Cheng Zhu wrote:
>
>> Update the raw event info for 74K according to the latest document.
>
>> +/*
>> + * MIPS document MD00519 (MIPS32(r) 74K(tm) Processor Core Family Software
>> + * User's Manual, Revision 01.05)
>> + */
>> #define IS_UNSUPPORTED_74K_EVENT(r, b) \
>> - ((r) == 5 || ((r)>= 135&& (r)<= 137) || \
>> - ((b)>= 10&& (b)<= 12) || (b) == 22 || (b) == 27 || \
>> - (b) == 33 || (b) == 34 || ((b)>= 47&& (b)<= 49) || \
>> - (r) == 178 || (b) == 55 || (b) == 57 || (b) == 60 || \
>> - (b) == 61 || (r) == 62 || (r) == 191 || \
>> - ((b)>= 64&& (b)<= 127))
>> + ((r) == 5 || (r) == 135 || ((b)>= 10&& (b)<= 12) || \
>> + (b) == 27 || (b) == 33 || (b) == 34 || (b) == 47 || \
>> + (b) == 48 || (r) == 178 || (r) == 187 || (b) == 60 || \
>> + (b) == 61 || (r) == 191 || (r) == 71 || (r) == 72 || \
>> + (b) == 73 || ((b)>= 77&& (b)<= 127))
>
> ...
> Afair there are MIPS licensee who have modified the counters to count
> extra events so I sense some madness in that direction.
A good point. Now that the user is working with raw events, the manual
is being used for sure. The user should have known what will be counted.
But we should keep the mappings for event cntr_mask and range. Although
they are also subject to changes by Arch licensees, patches will be
needed for their CPU in that case.
Deng-Cheng
next prev parent reply other threads:[~2011-11-10 10:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 10:55 [PATCH 0/4] MIPS/Perf-events: Functional fixes and cleanups Deng-Cheng Zhu
2011-10-24 10:55 ` Deng-Cheng Zhu
2011-10-24 10:55 ` [PATCH 1/4] MIPS/Perf-events: update the map of unsupported events for 74K Deng-Cheng Zhu
2011-10-24 10:55 ` Deng-Cheng Zhu
2011-11-09 20:40 ` Ralf Baechle
2011-11-09 22:00 ` Peter Zijlstra
2011-11-10 10:08 ` Deng-Cheng Zhu [this message]
2011-11-10 10:08 ` Deng-Cheng Zhu
2011-10-24 10:56 ` [PATCH 2/4] MIPS/Perf-events: remove erroneous check on active_events Deng-Cheng Zhu
2011-10-24 10:56 ` Deng-Cheng Zhu
2011-10-24 10:56 ` [PATCH 3/4] MIPS/Perf-events: temporarily connect event to its pmu at event init Deng-Cheng Zhu
2011-10-24 10:56 ` Deng-Cheng Zhu
2011-10-25 5:36 ` Deng-Cheng Zhu
2011-10-25 5:36 ` Deng-Cheng Zhu
2011-10-24 10:56 ` [PATCH 4/4] MIPS/Perf-events: Cleanup event->destroy " Deng-Cheng Zhu
2011-10-24 10:56 ` Deng-Cheng Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBBA2AA.6000901@mips.com \
--to=dczhu@mips.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.