bug when using ceph and keyring does not exist

bug when using ceph and keyring does not exist

[Smart Weblications GmbH - Florian Wiessner]

hi

i think i found a bug:

node02:/etc/ceph# ls
ceph.conf  keyring.mds.1  keyring.osd.1
node02:/etc/ceph# ceph
*** Caught signal (Segmentation fault) **
 in thread 7fb817589720
 ceph version 0.37-307-gae41f32 (commit:ae41f3232a39dbf33487ab02cbac292f58debea8)
 1: ceph() [0x470789]
 2: (()+0xef60) [0x7fb817170f60]
 3: (MonClient::_reopen_session()+0x5e4) [0x4845e4]
 4: (MonClient::authenticate(double)+0x1a1) [0x485281]
 5: (ceph_tool_common_init(ceph_tool_mode_t, bool)+0x55d) [0x452d2d]
 6: (main()+0x4fe) [0x44fa6e]
 7: (__libc_start_main()+0xfd) [0x7fb815b84c4d]
 8: ceph() [0x44e519]
Speicherzugriffsfehler
node02:/etc/ceph# scp root@node01:/etc/ceph/keyring .
keyring
                                            100%   92     0.1KB/s   00:00
node02:/etc/ceph# ceph
ceph> quit


so ceph seems to segfault when keyring file is missing...

a warning would be better :)
-- 

Mit freundlichen Grüßen,

Florian Wiessner

Smart Weblications GmbH
Martinsberger Str. 1
D-95119 Naila

fon.: +49 9282 9638 200
fax.: +49 9282 9638 205
24/7: +49 900 144 000 00 - 0,99 EUR/Min*
http://www.smart-weblications.de

--
Sitz der Gesellschaft: Naila
Geschäftsführer: Florian Wiessner
HRB-Nr.: HRB 3840 Amtsgericht Hof
*aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: bug when using ceph and keyring does not exist

[Tommi Virtanen]

On Sun, Nov 6, 2011 at 23:27, Smart Weblications GmbH - Florian
Wiessner <f.wiessner@smart-weblications.de> wrote:
> i think i found a bug:
...
> node02:/etc/ceph# ceph
> *** Caught signal (Segmentation fault) **
>  in thread 7fb817589720
>  ceph version 0.37-307-gae41f32 (commit:ae41f3232a39dbf33487ab02cbac292f58debea8)
>  1: ceph() [0x470789]
>  2: (()+0xef60) [0x7fb817170f60]
>  3: (MonClient::_reopen_session()+0x5e4) [0x4845e4]
>  4: (MonClient::authenticate(double)+0x1a1) [0x485281]
>  5: (ceph_tool_common_init(ceph_tool_mode_t, bool)+0x55d) [0x452d2d]
>  6: (main()+0x4fe) [0x44fa6e]
>  7: (__libc_start_main()+0xfd) [0x7fb815b84c4d]
>  8: ceph() [0x44e519]
> Speicherzugriffsfehler

So a missing keyring make ceph command crash. I see this commit, I
think Sam found the bug independently and fixed it already. Please try
again!

commit d4ef9215fd00b08a198986fde4af5635833555ec
Author: Samuel Just <samuel.just@dreamhost.com>
Date:   2011-11-07 15:04:02 -0800

    common: return null if mc.init() unsuccessful

    Prevents ceph.cc from segfaulting on missing keyring.

    Signed-off-by: Samuel Just <samuel.just@dreamhost.com>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: bug when using ceph and keyring does not exist

[Smart Weblications GmbH - Florian Wiessner]

Am 08.11.2011 18:57, schrieb Tommi Virtanen:
> On Sun, Nov 6, 2011 at 23:27, Smart Weblications GmbH - Florian
> Wiessner<f.wiessner@smart-weblications.de>  wrote:
>> i think i found a bug:
> ...

>
> So a missing keyring make ceph command crash. I see this commit, I
> think Sam found the bug independently and fixed it already. Please try
> again!
>
> commit d4ef9215fd00b08a198986fde4af5635833555ec
> Author: Samuel Just<samuel.just@dreamhost.com>
> Date:   2011-11-07 15:04:02 -0800
>
>      common: return null if mc.init() unsuccessful
>
>      Prevents ceph.cc from segfaulting on missing keyring.
>

yes, this fixes it - but a warning on stderr or so would be better imho..


-- 

Mit freundlichen Grüßen,

Florian Wiessner

Smart Weblications GmbH
Martinsberger Str. 1
D-95119 Naila

fon.: +49 9282 9638 200
fax.: +49 9282 9638 205
24/7: +49 900 144 000 00 - 0,99 EUR/Min*
http://www.smart-weblications.de

--
Sitz der Gesellschaft: Naila
Geschäftsführer: Florian Wiessner
HRB-Nr.: HRB 3840 Amtsgericht Hof
*aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html