All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc/kvm: fix build with older toolchains
Date: Thu, 10 Nov 2011 17:11:49 +0000	[thread overview]
Message-ID: <4EBC05D5.5080302@suse.de> (raw)
In-Reply-To: <20111107233656.GB20208@us.ibm.com>

On 11/08/2011 12:36 AM, Nishanth Aravamudan wrote:
> Fix KVM build for older toolchains (found with .powerpc64-unknown-linux-gnu-gcc
> (crosstool-NG-1.8.1) 4.3.2):
>
>    AS      arch/powerpc/kvm/book3s_hv_rmhandlers.o
> arch/powerpc/kvm/book3s_hv_rmhandlers.S: Assembler messages:
> arch/powerpc/kvm/book3s_hv_rmhandlers.S:1388: Error: Unrecognized opcode: `popcntw'
> make[1]: *** [arch/powerpc/kvm/book3s_hv_rmhandlers.o] Error 1
> make: *** [_module_arch/powerpc/kvm] Error 2
>
> Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>

Thanks, applied to kvm-ppc-next.


Alex

> diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> index 0607909..a053db1 100644
> --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> @@ -1385,7 +1385,7 @@ END_FTR_SECTION_IFCLR(CPU_FTR_ARCH_206)
>   	addi	r6,r5,VCORE_NAPPING_THREADS
>   31:	lwarx	r4,0,r6
>   	or	r4,r4,r0
> -	popcntw	r7,r4
> +	PPC_POPCNTW(r7,r4)
>   	cmpw	r7,r8
>   	bge	2f
>   	stwcx.	r4,0,r6
>


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc/kvm: fix build with older toolchains
Date: Thu, 10 Nov 2011 18:11:49 +0100	[thread overview]
Message-ID: <4EBC05D5.5080302@suse.de> (raw)
In-Reply-To: <20111107233656.GB20208@us.ibm.com>

On 11/08/2011 12:36 AM, Nishanth Aravamudan wrote:
> Fix KVM build for older toolchains (found with .powerpc64-unknown-linux-gnu-gcc
> (crosstool-NG-1.8.1) 4.3.2):
>
>    AS      arch/powerpc/kvm/book3s_hv_rmhandlers.o
> arch/powerpc/kvm/book3s_hv_rmhandlers.S: Assembler messages:
> arch/powerpc/kvm/book3s_hv_rmhandlers.S:1388: Error: Unrecognized opcode: `popcntw'
> make[1]: *** [arch/powerpc/kvm/book3s_hv_rmhandlers.o] Error 1
> make: *** [_module_arch/powerpc/kvm] Error 2
>
> Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>

Thanks, applied to kvm-ppc-next.


Alex

> diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> index 0607909..a053db1 100644
> --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> @@ -1385,7 +1385,7 @@ END_FTR_SECTION_IFCLR(CPU_FTR_ARCH_206)
>   	addi	r6,r5,VCORE_NAPPING_THREADS
>   31:	lwarx	r4,0,r6
>   	or	r4,r4,r0
> -	popcntw	r7,r4
> +	PPC_POPCNTW(r7,r4)
>   	cmpw	r7,r8
>   	bge	2f
>   	stwcx.	r4,0,r6
>

  reply	other threads:[~2011-11-10 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 23:36 [PATCH] powerpc/kvm: fix build with older toolchains Nishanth Aravamudan
2011-11-07 23:36 ` Nishanth Aravamudan
2011-11-10 17:11 ` Alexander Graf [this message]
2011-11-10 17:11   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBC05D5.5080302@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nacc@us.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.