From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, scdbackup@gmx.net, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/5] atapi: kill MODE SENSE(6), fix MODE SENSE(10)
Date: Fri, 11 Nov 2011 14:38:44 +0100 [thread overview]
Message-ID: <4EBD2564.6080105@redhat.com> (raw)
In-Reply-To: <4EBD24F0.9090105@redhat.com>
On 11/11/2011 02:36 PM, Kevin Wolf wrote:
>> > @@ -717,11 +712,10 @@ static void cmd_mode_sense(IDEState *s, uint8_t *buf)
>> > buf[12] = 0x00;
>> > buf[13] = 0x00;
>> > buf[14] = 0x00;
>> > - buf[15] = 0x00;
> Why did you drop this? It still seems to be part of the buffer.
Ouch. No idea.
Actually, I think it's best if these patches wait until Thomas can give
a shot at testing them. If that means missing 1.0, so be it.
Paolo
next prev parent reply other threads:[~2011-11-11 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 16:01 [Qemu-devel] [PATCH 0/5] scsi/atapi: MMC fixes Paolo Bonzini
2011-11-10 16:01 ` [Qemu-devel] [PATCH 1/5] atapi: kill MODE SENSE(6), fix MODE SENSE(10) Paolo Bonzini
2011-11-11 13:36 ` Kevin Wolf
2011-11-11 13:38 ` Paolo Bonzini [this message]
2011-11-11 15:14 ` [Qemu-devel] " Thomas Schmitt
2011-11-10 16:01 ` [Qemu-devel] [PATCH 2/5] scsi: update list of commands Paolo Bonzini
2011-11-11 14:08 ` Kevin Wolf
2011-11-10 16:01 ` [Qemu-devel] [PATCH 3/5] scsi: fix parsing of allocation length field Paolo Bonzini
2011-11-10 16:01 ` [Qemu-devel] [PATCH 4/5] scsi: remove block descriptors from CDs Paolo Bonzini
2011-11-10 16:01 ` [Qemu-devel] [PATCH 5/5] scsi-block: special case CD burning commands Paolo Bonzini
2011-11-10 18:17 ` [Qemu-devel] [PATCH 0/5] scsi/atapi: MMC fixes Thomas Schmitt
2011-11-11 12:08 ` Paolo Bonzini
2011-11-11 14:47 ` Thomas Schmitt
2011-11-11 4:09 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBD2564.6080105@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=scdbackup@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.