All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: Paul Mackerras <paulus@samba.org>,
	kvm-ppc <kvm-ppc@vger.kernel.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N
Date: Fri, 11 Nov 2011 16:01:56 +0000	[thread overview]
Message-ID: <4EBD46F4.5040503@suse.de> (raw)
In-Reply-To: <12283.1320977000@neuling.org>

On 11/11/2011 03:03 AM, Michael Neuling wrote:
> Currently kvmppc_start_thread() tries to wake other SMT threads via
> xics_wake_cpu().  Unfortunately xics_wake_cpu only exists when
> CONFIG_SMP=Y so when compiling with CONFIG_SMP=N we get:
>
>    arch/powerpc/kvm/built-in.o: In function `.kvmppc_start_thread':
>    book3s_hv.c:(.text+0xa1e0): undefined reference to `.xics_wake_cpu'
>
> The following should be fine since kvmppc_start_thread() shouldn't
> called to start non-zero threads when SMP=N since threads_per_core=1.
>
> Signed-off-by: Michael Neuling<mikey@neuling.org>

Thanks, applied to kvm-ppc-next. Please CC kvm-ppc@vger next time :).


Alex


WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Michael Neuling <mikey@neuling.org>
Cc: Paul Mackerras <paulus@samba.org>,
	kvm-ppc <kvm-ppc@vger.kernel.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N
Date: Fri, 11 Nov 2011 17:01:56 +0100	[thread overview]
Message-ID: <4EBD46F4.5040503@suse.de> (raw)
In-Reply-To: <12283.1320977000@neuling.org>

On 11/11/2011 03:03 AM, Michael Neuling wrote:
> Currently kvmppc_start_thread() tries to wake other SMT threads via
> xics_wake_cpu().  Unfortunately xics_wake_cpu only exists when
> CONFIG_SMP=Y so when compiling with CONFIG_SMP=N we get:
>
>    arch/powerpc/kvm/built-in.o: In function `.kvmppc_start_thread':
>    book3s_hv.c:(.text+0xa1e0): undefined reference to `.xics_wake_cpu'
>
> The following should be fine since kvmppc_start_thread() shouldn't
> called to start non-zero threads when SMP=N since threads_per_core=1.
>
> Signed-off-by: Michael Neuling<mikey@neuling.org>

Thanks, applied to kvm-ppc-next. Please CC kvm-ppc@vger next time :).


Alex

  reply	other threads:[~2011-11-11 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11  2:03 [PATCH] powerpc kvm: fix kvmppc_start_thread() for CONFIG_SMP=N Michael Neuling
2011-11-11 16:01 ` Alexander Graf [this message]
2011-11-11 16:01   ` Alexander Graf
2011-11-12  4:07   ` Michael Neuling
2011-11-12  4:07     ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBD46F4.5040503@suse.de \
    --to=agraf@suse.de \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.