All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Miller <mike.miller@hp.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"scameron@beardog.cce.hp.com" <scameron@beardog.cce.hp.com>,
	ISS StorageDev <iss_storagedev@hp.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH V2 5/6] scsi/hpsa: Disable ASPM
Date: Fri, 11 Nov 2011 10:16:19 -0600	[thread overview]
Message-ID: <4EBD4A53.10709@hp.com> (raw)
In-Reply-To: <1321028064-644-6-git-send-email-mjg@redhat.com>

On 11/11/2011 10:14 AM, Matthew Garrett wrote:
> The Windows driver .inf disables ASPM on hpsa devices. Do the same.
>
> Signed-off-by: Matthew Garrett<mjg@redhat.com>
> Cc: scameron@beardog.cce.hp.com
> Cc: iss_storagedev@hp.com
> Cc: linux-scsi@vger.kernel.org
> ---
>   drivers/scsi/hpsa.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index e76107b..865d452 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -23,6 +23,7 @@
>   #include<linux/interrupt.h>
>   #include<linux/types.h>
>   #include<linux/pci.h>
> +#include<linux/pci-aspm.h>
>   #include<linux/kernel.h>
>   #include<linux/slab.h>
>   #include<linux/delay.h>
> @@ -3922,6 +3923,10 @@ static int __devinit hpsa_pci_init(struct ctlr_info *h)
>   		dev_warn(&h->pdev->dev, "controller appears to be disabled\n");
>   		return -ENODEV;
>   	}
> +
> +	pci_disable_link_state(h->pdev, PCIE_LINK_STATE_L0S |
> +			       PCIE_LINK_STATE_L1 | PCIE_LINK_STATE_CLKPM);
> +
>   	err = pci_enable_device(h->pdev);
>   	if (err) {
>   		dev_warn(&h->pdev->dev, "unable to enable PCI device\n");

Acked-by: Mike Miller <mike.miller@hp.com>

  reply	other threads:[~2011-11-11 16:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 16:14 [V2] Disable ASPM on various devices Matthew Garrett
2011-11-11 16:14 ` [PATCH V2 1/6] net/ethernet/atl1c: Disable ASPM on various chipsets Matthew Garrett
2011-11-14  5:30   ` David Miller
2011-11-14  5:34     ` David Miller
2011-11-11 16:14 ` [PATCH V2 2/6] net/ethernet/atl1e: Disable ASPM Matthew Garrett
2011-11-14  5:31   ` David Miller
2011-11-14  5:33     ` David Miller
2011-11-14  5:33       ` David Miller
2011-11-14 15:44       ` Matthew Garrett
2011-11-11 16:14 ` [PATCH V2 3/6] net/ethernet/jme: " Matthew Garrett
2011-11-14  5:31   ` David Miller
2011-11-11 16:14 ` [PATCH V2 4/6] block/cciss: " Matthew Garrett
2011-11-11 16:15   ` Mike Miller
2011-11-11 21:06     ` Jens Axboe
2011-11-11 16:14 ` [PATCH V2 5/6] scsi/hpsa: " Matthew Garrett
2011-11-11 16:16   ` Mike Miller [this message]
     [not found] ` <1321028064-644-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-11-11 16:14   ` [PATCH V2 6/6] infiniband/nes: " Matthew Garrett
2011-11-11 16:14     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBD4A53.10709@hp.com \
    --to=mike.miller@hp.com \
    --cc=iss_storagedev@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=scameron@beardog.cce.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.