All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Mike Miller <mike.miller@hp.com>
Cc: Matthew Garrett <mjg@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	ISS StorageDev <iss_storagedev@hp.com>
Subject: Re: [PATCH V2 4/6] block/cciss: Disable ASPM
Date: Fri, 11 Nov 2011 22:06:39 +0100	[thread overview]
Message-ID: <4EBD8E5F.1010200@kernel.dk> (raw)
In-Reply-To: <4EBD4A31.2070609@hp.com>

On 2011-11-11 17:15, Mike Miller wrote:
> On 11/11/2011 10:14 AM, Matthew Garrett wrote:
>> The Windows driver .inf disables ASPM on all cciss devices. Do the same.
>>
>> Signed-off-by: Matthew Garrett<mjg@redhat.com>
>> Cc: mike.miller@hp.com
>> Cc: iss_storagedev@hp.com
>> Cc: axboe@kernel.dk
>> ---
>>   drivers/block/cciss.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
>> index 486f94e..92d8a2f 100644
>> --- a/drivers/block/cciss.c
>> +++ b/drivers/block/cciss.c
>> @@ -24,6 +24,7 @@
>>   #include<linux/interrupt.h>
>>   #include<linux/types.h>
>>   #include<linux/pci.h>
>> +#include<linux/pci-aspm.h>
>>   #include<linux/kernel.h>
>>   #include<linux/slab.h>
>>   #include<linux/delay.h>
>> @@ -4319,6 +4320,10 @@ static int __devinit cciss_pci_init(ctlr_info_t *h)
>>           dev_warn(&h->pdev->dev, "controller appears to be disabled\n");
>>           return -ENODEV;
>>       }
>> +
>> +    pci_disable_link_state(h->pdev, PCIE_LINK_STATE_L0S |
>> +                   PCIE_LINK_STATE_L1 | PCIE_LINK_STATE_CLKPM);
>> +
>>       err = pci_enable_device(h->pdev);
>>       if (err) {
>>           dev_warn(&h->pdev->dev, "Unable to Enable PCI device\n");
> 
> Acked-by: Mike Miller <mike.miller@hp.com>

Applied for 3.2, thanks.

-- 
Jens Axboe


  reply	other threads:[~2011-11-11 21:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 16:14 [V2] Disable ASPM on various devices Matthew Garrett
2011-11-11 16:14 ` [PATCH V2 1/6] net/ethernet/atl1c: Disable ASPM on various chipsets Matthew Garrett
2011-11-14  5:30   ` David Miller
2011-11-14  5:34     ` David Miller
2011-11-11 16:14 ` [PATCH V2 2/6] net/ethernet/atl1e: Disable ASPM Matthew Garrett
2011-11-14  5:31   ` David Miller
2011-11-14  5:33     ` David Miller
2011-11-14  5:33       ` David Miller
2011-11-14 15:44       ` Matthew Garrett
2011-11-11 16:14 ` [PATCH V2 3/6] net/ethernet/jme: " Matthew Garrett
2011-11-14  5:31   ` David Miller
2011-11-11 16:14 ` [PATCH V2 4/6] block/cciss: " Matthew Garrett
2011-11-11 16:15   ` Mike Miller
2011-11-11 21:06     ` Jens Axboe [this message]
2011-11-11 16:14 ` [PATCH V2 5/6] scsi/hpsa: " Matthew Garrett
2011-11-11 16:16   ` Mike Miller
     [not found] ` <1321028064-644-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-11-11 16:14   ` [PATCH V2 6/6] infiniband/nes: " Matthew Garrett
2011-11-11 16:14     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBD8E5F.1010200@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=iss_storagedev@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.