From: Wang Sheng-Hui <shhuiw@gmail.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm: cleanup the comment for head/tail pages of compound pages in mm/page_alloc.c
Date: Tue, 15 Nov 2011 16:06:16 +0800 [thread overview]
Message-ID: <4EC21D78.4080508@gmail.com> (raw)
Per the void prep_compound_page(struct page *page, unsigned long order) code,
compound pages use PG_head/PG_tail, and only tail pages point at head page
using their ->first_page field.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
mm/page_alloc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6e8ecb6..f645ce8 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -332,8 +332,8 @@ out:
*
* The remaining PAGE_SIZE pages are called "tail pages".
*
- * All pages have PG_compound set. All pages have their ->private pointing at
- * the head page (even the head page has this).
+ * Head page has PG_head set, and all tail pages have PG_tail set. All tail
+ * pages have their ->first_page pointing at the head page.
*
* The first tail page's ->lru.next holds the address of the compound page's
* put_page() function. Its ->lru.prev holds the order of allocation.
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Wang Sheng-Hui <shhuiw@gmail.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm: cleanup the comment for head/tail pages of compound pages in mm/page_alloc.c
Date: Tue, 15 Nov 2011 16:06:16 +0800 [thread overview]
Message-ID: <4EC21D78.4080508@gmail.com> (raw)
Per the void prep_compound_page(struct page *page, unsigned long order) code,
compound pages use PG_head/PG_tail, and only tail pages point at head page
using their ->first_page field.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
mm/page_alloc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 6e8ecb6..f645ce8 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -332,8 +332,8 @@ out:
*
* The remaining PAGE_SIZE pages are called "tail pages".
*
- * All pages have PG_compound set. All pages have their ->private pointing at
- * the head page (even the head page has this).
+ * Head page has PG_head set, and all tail pages have PG_tail set. All tail
+ * pages have their ->first_page pointing at the head page.
*
* The first tail page's ->lru.next holds the address of the compound page's
* put_page() function. Its ->lru.prev holds the order of allocation.
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2011-11-15 8:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 8:06 Wang Sheng-Hui [this message]
2011-11-15 8:06 ` [PATCH] mm: cleanup the comment for head/tail pages of compound pages in mm/page_alloc.c Wang Sheng-Hui
2011-11-15 13:24 ` Michal Hocko
2011-11-15 13:24 ` Michal Hocko
2011-11-16 0:05 ` Wang Sheng-Hui
2011-11-16 0:05 ` Wang Sheng-Hui
2011-11-17 8:22 ` Michal Hocko
2011-11-17 8:22 ` Michal Hocko
2011-11-17 9:54 ` Jiri Kosina
2011-11-17 9:54 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC21D78.4080508@gmail.com \
--to=shhuiw@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.