* [PATCHv2 1/2] arm: samsung: support the second capability for samsung-soc @ 2011-11-03 2:35 Jaehoon Chung 2011-11-11 6:35 ` Jae hoon Chung 2011-11-15 9:53 ` Kukjin Kim 0 siblings, 2 replies; 4+ messages in thread From: Jaehoon Chung @ 2011-11-03 2:35 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-mmc, Chris Ball, Kyungmin Park, 'kgene kim' In mmc, there are capabilities and use the host_caps. That capability is expressed with bit[0:31]. But now..already filled the bit[0:31]... so we need to denote with the other capability field. (if we want to use the cache, powerclass, etc for eMMC..this field is necessary) Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> Signed-off-by: Kyungmin Park <Kyungmin.park@samsung.com> --- Changelog v2: - based-on samsung-soc's for-next tree. arch/arm/plat-samsung/include/plat/sdhci.h | 2 ++ arch/arm/plat-samsung/platformdata.c | 2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-samsung/include/plat/sdhci.h index dcff7dd..bf33ea1 100644 --- a/arch/arm/plat-samsung/include/plat/sdhci.h +++ b/arch/arm/plat-samsung/include/plat/sdhci.h @@ -40,6 +40,7 @@ enum clk_types { * struct s3c_sdhci_platdata() - Platform device data for Samsung SDHCI * @max_width: The maximum number of data bits supported. * @host_caps: Standard MMC host capabilities bit field. + * @host_caps2: The Second Standard MMC host capabilities bit field. * @cd_type: Type of Card Detection method (see cd_types enum above) * @clk_type: Type of clock divider method (see clk_types enum above) * @ext_cd_init: Initialize external card detect subsystem. Called on @@ -63,6 +64,7 @@ enum clk_types { struct s3c_sdhci_platdata { unsigned int max_width; unsigned int host_caps; + unsigned int host_caps2; enum cd_types cd_type; enum clk_types clk_type; diff --git a/arch/arm/plat-samsung/platformdata.c b/arch/arm/plat-samsung/platformdata.c index 4c9a207..5ffcf46 100644 --- a/arch/arm/plat-samsung/platformdata.c +++ b/arch/arm/plat-samsung/platformdata.c @@ -54,4 +54,6 @@ void s3c_sdhci_set_platdata(struct s3c_sdhci_platdata *pd, set->host_caps |= pd->host_caps; if (pd->clk_type) set->clk_type = pd->clk_type; + if (pd->host_caps2) + set->host_caps2 |= pd->host_caps2; } ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv2 1/2] arm: samsung: support the second capability for samsung-soc 2011-11-03 2:35 [PATCHv2 1/2] arm: samsung: support the second capability for samsung-soc Jaehoon Chung @ 2011-11-11 6:35 ` Jae hoon Chung 2011-11-15 9:53 ` Kukjin Kim 1 sibling, 0 replies; 4+ messages in thread From: Jae hoon Chung @ 2011-11-11 6:35 UTC (permalink / raw) To: Jaehoon Chung Cc: linux-samsung-soc, linux-mmc, Chris Ball, Kyungmin Park, kgene kim Hi kgene How about this patch? this patch must add the platform data. Thanks, Jaehoon Chung 2011/11/3 Jaehoon Chung <jh80.chung@samsung.com>: > In mmc, there are capabilities and use the host_caps. > That capability is expressed with bit[0:31]. > But now..already filled the bit[0:31]... > so we need to denote with the other capability field. > (if we want to use the cache, powerclass, etc for eMMC..this field is necessary) > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > Signed-off-by: Kyungmin Park <Kyungmin.park@samsung.com> > --- > Changelog v2: > - based-on samsung-soc's for-next tree. > > arch/arm/plat-samsung/include/plat/sdhci.h | 2 ++ > arch/arm/plat-samsung/platformdata.c | 2 ++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-samsung/include/plat/sdhci.h > index dcff7dd..bf33ea1 100644 > --- a/arch/arm/plat-samsung/include/plat/sdhci.h > +++ b/arch/arm/plat-samsung/include/plat/sdhci.h > @@ -40,6 +40,7 @@ enum clk_types { > * struct s3c_sdhci_platdata() - Platform device data for Samsung SDHCI > * @max_width: The maximum number of data bits supported. > * @host_caps: Standard MMC host capabilities bit field. > + * @host_caps2: The Second Standard MMC host capabilities bit field. > * @cd_type: Type of Card Detection method (see cd_types enum above) > * @clk_type: Type of clock divider method (see clk_types enum above) > * @ext_cd_init: Initialize external card detect subsystem. Called on > @@ -63,6 +64,7 @@ enum clk_types { > struct s3c_sdhci_platdata { > unsigned int max_width; > unsigned int host_caps; > + unsigned int host_caps2; > enum cd_types cd_type; > enum clk_types clk_type; > > diff --git a/arch/arm/plat-samsung/platformdata.c b/arch/arm/plat-samsung/platformdata.c > index 4c9a207..5ffcf46 100644 > --- a/arch/arm/plat-samsung/platformdata.c > +++ b/arch/arm/plat-samsung/platformdata.c > @@ -54,4 +54,6 @@ void s3c_sdhci_set_platdata(struct s3c_sdhci_platdata *pd, > set->host_caps |= pd->host_caps; > if (pd->clk_type) > set->clk_type = pd->clk_type; > + if (pd->host_caps2) > + set->host_caps2 |= pd->host_caps2; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCHv2 1/2] arm: samsung: support the second capability for samsung-soc 2011-11-03 2:35 [PATCHv2 1/2] arm: samsung: support the second capability for samsung-soc Jaehoon Chung 2011-11-11 6:35 ` Jae hoon Chung @ 2011-11-15 9:53 ` Kukjin Kim 2011-11-15 10:18 ` Jaehoon Chung 1 sibling, 1 reply; 4+ messages in thread From: Kukjin Kim @ 2011-11-15 9:53 UTC (permalink / raw) To: 'Jaehoon Chung', linux-samsung-soc Cc: 'linux-mmc', 'Chris Ball', 'Kyungmin Park' Jaehoon Chung wrote: > > In mmc, there are capabilities and use the host_caps. > That capability is expressed with bit[0:31]. > But now..already filled the bit[0:31]... > so we need to denote with the other capability field. > (if we want to use the cache, powerclass, etc for eMMC..this field is necessary) > Hi, This description is better than previous. However, I wonder this is _really_ used for eMMC at sdhci-s3c.c driver. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > Signed-off-by: Kyungmin Park <Kyungmin.park@samsung.com> > --- > Changelog v2: > - based-on samsung-soc's for-next tree. > > arch/arm/plat-samsung/include/plat/sdhci.h | 2 ++ > arch/arm/plat-samsung/platformdata.c | 2 ++ > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat- > samsung/include/plat/sdhci.h > index dcff7dd..bf33ea1 100644 > --- a/arch/arm/plat-samsung/include/plat/sdhci.h > +++ b/arch/arm/plat-samsung/include/plat/sdhci.h > @@ -40,6 +40,7 @@ enum clk_types { > * struct s3c_sdhci_platdata() - Platform device data for Samsung SDHCI > * @max_width: The maximum number of data bits supported. > * @host_caps: Standard MMC host capabilities bit field. > + * @host_caps2: The Second Standard MMC host capabilities bit field. > * @cd_type: Type of Card Detection method (see cd_types enum above) > * @clk_type: Type of clock divider method (see clk_types enum above) > * @ext_cd_init: Initialize external card detect subsystem. Called on > @@ -63,6 +64,7 @@ enum clk_types { > struct s3c_sdhci_platdata { > unsigned int max_width; > unsigned int host_caps; > + unsigned int host_caps2; > enum cd_types cd_type; > enum clk_types clk_type; > > diff --git a/arch/arm/plat-samsung/platformdata.c b/arch/arm/plat- > samsung/platformdata.c > index 4c9a207..5ffcf46 100644 > --- a/arch/arm/plat-samsung/platformdata.c > +++ b/arch/arm/plat-samsung/platformdata.c > @@ -54,4 +54,6 @@ void s3c_sdhci_set_platdata(struct s3c_sdhci_platdata *pd, > set->host_caps |= pd->host_caps; > if (pd->clk_type) > set->clk_type = pd->clk_type; > + if (pd->host_caps2) > + set->host_caps2 |= pd->host_caps2; > } ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv2 1/2] arm: samsung: support the second capability for samsung-soc 2011-11-15 9:53 ` Kukjin Kim @ 2011-11-15 10:18 ` Jaehoon Chung 0 siblings, 0 replies; 4+ messages in thread From: Jaehoon Chung @ 2011-11-15 10:18 UTC (permalink / raw) To: Kukjin Kim Cc: 'Jaehoon Chung', linux-samsung-soc, 'linux-mmc', 'Chris Ball', 'Kyungmin Park' Hi Kukjin On 11/15/2011 06:53 PM, Kukjin Kim wrote: > Jaehoon Chung wrote: >> >> In mmc, there are capabilities and use the host_caps. >> That capability is expressed with bit[0:31]. >> But now..already filled the bit[0:31]... >> so we need to denote with the other capability field. >> (if we want to use the cache, powerclass, etc for eMMC..this field is > necessary) >> > Hi, > > This description is better than previous. > However, I wonder this is _really_ used for eMMC at sdhci-s3c.c driver. You means that samsung is using the other, right? If that is reason, i think that we need to add the second capability in future. Because, Second capability also need for SD/SDIO interface. (if need not to add the second capability, how do you add more capabilities for SD/SDIO) Best Regards, Jaehoon Chung > > Thanks. > > Best regards, > Kgene. > -- > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, > SW Solution Development Team, Samsung Electronics Co., Ltd. > >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> Signed-off-by: Kyungmin Park <Kyungmin.park@samsung.com> >> --- >> Changelog v2: >> - based-on samsung-soc's for-next tree. >> >> arch/arm/plat-samsung/include/plat/sdhci.h | 2 ++ >> arch/arm/plat-samsung/platformdata.c | 2 ++ >> 2 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat- >> samsung/include/plat/sdhci.h >> index dcff7dd..bf33ea1 100644 >> --- a/arch/arm/plat-samsung/include/plat/sdhci.h >> +++ b/arch/arm/plat-samsung/include/plat/sdhci.h >> @@ -40,6 +40,7 @@ enum clk_types { >> * struct s3c_sdhci_platdata() - Platform device data for Samsung SDHCI >> * @max_width: The maximum number of data bits supported. >> * @host_caps: Standard MMC host capabilities bit field. >> + * @host_caps2: The Second Standard MMC host capabilities bit field. >> * @cd_type: Type of Card Detection method (see cd_types enum above) >> * @clk_type: Type of clock divider method (see clk_types enum above) >> * @ext_cd_init: Initialize external card detect subsystem. Called on >> @@ -63,6 +64,7 @@ enum clk_types { >> struct s3c_sdhci_platdata { >> unsigned int max_width; >> unsigned int host_caps; >> + unsigned int host_caps2; >> enum cd_types cd_type; >> enum clk_types clk_type; >> >> diff --git a/arch/arm/plat-samsung/platformdata.c b/arch/arm/plat- >> samsung/platformdata.c >> index 4c9a207..5ffcf46 100644 >> --- a/arch/arm/plat-samsung/platformdata.c >> +++ b/arch/arm/plat-samsung/platformdata.c >> @@ -54,4 +54,6 @@ void s3c_sdhci_set_platdata(struct s3c_sdhci_platdata > *pd, >> set->host_caps |= pd->host_caps; >> if (pd->clk_type) >> set->clk_type = pd->clk_type; >> + if (pd->host_caps2) >> + set->host_caps2 |= pd->host_caps2; >> } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-15 10:18 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-11-03 2:35 [PATCHv2 1/2] arm: samsung: support the second capability for samsung-soc Jaehoon Chung 2011-11-11 6:35 ` Jae hoon Chung 2011-11-15 9:53 ` Kukjin Kim 2011-11-15 10:18 ` Jaehoon Chung
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.