All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@adurom.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h
Date: Tue, 15 Nov 2011 18:37:08 +0200	[thread overview]
Message-ID: <4EC29534.7010502@adurom.com> (raw)
In-Reply-To: <1321356224-5053-1-git-send-email-sangwook.lee@linaro.org>

Hi Sangwook,

On 11/15/2011 01:23 PM, Sangwook Lee wrote:
> The patch series proposes to rename ath9k_platform.h to "ath_platform.h
> This header file handles platform data used only for ath9k,
> but it can used by ath6k as well. We can take "wl12xx.h" as
> as a example. Please let us change this file name so that
> other Atheors WLANs use this file for their own platform data

ath9k and ath6kl are very different devices, I'm not sure if sharing a
platfrom struct between the two is really a good idea. Most likely there
is very little the two drivers can share. What are your plans here?

I myself was thinking that we would have include/linux/ath6kl.h
dedicated just for ath6kl. That would makes things simpler.

Kalle

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@adurom.com>
To: Sangwook Lee <sangwook.lee@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
	linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org,
	ralf@linux-mips.org, juhosg@openwrt.org,
	rodrigue@qca.qualcomm.com, linville@tuxdriver.com,
	rmanohar@qca.qualcomm.com, patches@linaro.org
Subject: Re: [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h
Date: Tue, 15 Nov 2011 18:37:08 +0200	[thread overview]
Message-ID: <4EC29534.7010502@adurom.com> (raw)
In-Reply-To: <1321356224-5053-1-git-send-email-sangwook.lee@linaro.org>

Hi Sangwook,

On 11/15/2011 01:23 PM, Sangwook Lee wrote:
> The patch series proposes to rename ath9k_platform.h to "ath_platform.h
> This header file handles platform data used only for ath9k,
> but it can used by ath6k as well. We can take "wl12xx.h" as
> as a example. Please let us change this file name so that
> other Atheors WLANs use this file for their own platform data

ath9k and ath6kl are very different devices, I'm not sure if sharing a
platfrom struct between the two is really a good idea. Most likely there
is very little the two drivers can share. What are your plans here?

I myself was thinking that we would have include/linux/ath6kl.h
dedicated just for ath6kl. That would makes things simpler.

Kalle

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@adurom.com>
To: Sangwook Lee <sangwook.lee@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
	linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net,
	ralf@linux-mips.org, juhosg@openwrt.org,
	rodrigue@qca.qualcomm.com, linville@tuxdriver.com,
	rmanohar@qca.qualcomm.com, patches@linaro.org
Subject: Re: [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h
Date: Tue, 15 Nov 2011 18:37:08 +0200	[thread overview]
Message-ID: <4EC29534.7010502@adurom.com> (raw)
In-Reply-To: <1321356224-5053-1-git-send-email-sangwook.lee@linaro.org>

Hi Sangwook,

On 11/15/2011 01:23 PM, Sangwook Lee wrote:
> The patch series proposes to rename ath9k_platform.h to "ath_platform.h
> This header file handles platform data used only for ath9k,
> but it can used by ath6k as well. We can take "wl12xx.h" as
> as a example. Please let us change this file name so that
> other Atheors WLANs use this file for their own platform data

ath9k and ath6kl are very different devices, I'm not sure if sharing a
platfrom struct between the two is really a good idea. Most likely there
is very little the two drivers can share. What are your plans here?

I myself was thinking that we would have include/linux/ath6kl.h
dedicated just for ath6kl. That would makes things simpler.

Kalle

  parent reply	other threads:[~2011-11-15 16:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 11:23 [ath9k-devel] [PATCH] ath9k: rename ath9k_platform.h to ath_platform.h Sangwook Lee
2011-11-15 11:23 ` Sangwook Lee
2011-11-15 11:23 ` Sangwook Lee
2011-11-15 16:09 ` [ath9k-devel] " Luis R. Rodriguez
2011-11-15 16:09   ` Luis R. Rodriguez
2011-11-15 16:09   ` Luis R. Rodriguez
2011-11-15 16:28   ` [ath9k-devel] " Daniel Golle
2011-11-16 21:11   ` Gabor Juhos
2011-11-16 21:11     ` Gabor Juhos
2011-11-16 21:11     ` Gabor Juhos
2011-11-15 16:37 ` Kalle Valo [this message]
2011-11-15 16:37   ` Kalle Valo
2011-11-15 16:37   ` Kalle Valo
2011-11-16 11:34   ` [ath9k-devel] " Sangwook Lee
2011-11-17 19:06     ` Kalle Valo
2011-11-17 19:06       ` Kalle Valo
2011-11-17 19:06       ` Kalle Valo
2011-11-17 19:06       ` Kalle Valo
2011-11-22  9:17       ` [ath9k-devel] " Sangwook Lee
2011-11-22  9:17         ` Sangwook Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC29534.7010502@adurom.com \
    --to=kvalo@adurom.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.