All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix RHBZ 754198 (multiple dmeventd snapshot extensions)
Date: Tue, 15 Nov 2011 23:23:44 +0100	[thread overview]
Message-ID: <4EC2E670.6000208@redhat.com> (raw)
In-Reply-To: <87pqgtxczr.fsf@aldalome.int.mornfall.net.>

On 11/15/2011 11:00 PM, Petr Rockai wrote:
> the attached patch should fix the problem encountered in 754198. Namely,
> we failed to reset the percent threshold for the next check after
> extending a snapshot. To this end, I have added a special exit code,
> ENO_ACTION_NEEDED -- however, this is not absolutely required, and is
> only an optimisation. On the other hand, it is likely an important
> optimisation, because without this, all snapshots filled above 50 % will
> run a LVM command (with all the associated overhead) every 10
> seconds. There are more possible uses for this new exit code, so I think
> it's a good idea anyway.
> 
> Documentation *might* need updating (although it's currently only used
> by --use-policies, which is not an entirely user-level option...).
> 
> Other than that, the patch is relatively straightforward.

For me this seems ok, ack.
(dmeventd/lvm interaction through calling lvm binary strange anyway...)

Milan



  reply	other threads:[~2011-11-15 22:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15 22:00 [PATCH] Fix RHBZ 754198 (multiple dmeventd snapshot extensions) Petr Rockai
2011-11-15 22:23 ` Milan Broz [this message]
     [not found]   ` <20111116000020.GA3294@agk-dp.fab.redhat.com>
2011-11-16  9:30     ` Petr Rockai
2011-11-16  9:44       ` Zdenek Kabelac
2011-11-16 10:28       ` Alasdair G Kergon
2011-11-16  1:20 ` Alasdair G Kergon
2011-11-16  9:41   ` Petr Rockai
2011-11-16 10:59     ` Alasdair G Kergon
2011-11-16 13:07       ` Alasdair G Kergon
2011-11-18  9:52         ` Petr Rockai
2011-11-18 17:14           ` Zdenek Kabelac
2011-11-18 19:46             ` Petr Rockai
2011-11-18 19:56               ` Alasdair G Kergon
2011-11-18 20:28                 ` Petr Rockai
2011-11-18 21:19                   ` Petr Rockai
2011-11-18 20:48               ` Zdenek Kabelac
2011-11-18 20:53                 ` Alasdair G Kergon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC2E670.6000208@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.