From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
Liam Girdwood <lrg@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: pxa: add support for Raumfeld DDX
Date: Wed, 16 Nov 2011 15:19:01 +0100 [thread overview]
Message-ID: <4EC3C655.6000100@gmail.com> (raw)
In-Reply-To: <20111116141130.GF29986@opensource.wolfsonmicro.com>
On 11/16/2011 03:11 PM, Mark Brown wrote:
> On Wed, Nov 16, 2011 at 03:06:46PM +0100, Daniel Mack wrote:
>> Sorry, I still don't get it. All implementations I can find call
>> snd_soc_dai_set_fmt() for the cpu and codec dais from the
>> .ops->hw_params function they reference from their snd_soc_dai_links.
>> Just like this new code does as well. What am I missing?
>
> Are you *sure* you're looking at current code? The dai_fmt field isn't
> that obscurely named...
Grrr. Sorry for that. We're based on 3.1 here, I should have noticed.
I'll rebase, do all necessary cleanups and resubmit.
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: zonque@gmail.com (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: add support for Raumfeld DDX
Date: Wed, 16 Nov 2011 15:19:01 +0100 [thread overview]
Message-ID: <4EC3C655.6000100@gmail.com> (raw)
In-Reply-To: <20111116141130.GF29986@opensource.wolfsonmicro.com>
On 11/16/2011 03:11 PM, Mark Brown wrote:
> On Wed, Nov 16, 2011 at 03:06:46PM +0100, Daniel Mack wrote:
>> Sorry, I still don't get it. All implementations I can find call
>> snd_soc_dai_set_fmt() for the cpu and codec dais from the
>> .ops->hw_params function they reference from their snd_soc_dai_links.
>> Just like this new code does as well. What am I missing?
>
> Are you *sure* you're looking at current code? The dai_fmt field isn't
> that obscurely named...
Grrr. Sorry for that. We're based on 3.1 here, I should have noticed.
I'll rebase, do all necessary cleanups and resubmit.
Daniel
next prev parent reply other threads:[~2011-11-16 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 10:26 [PATCH] ARM: pxa: add support for Raumfeld DDX Daniel Mack
2011-11-07 10:26 ` Daniel Mack
2011-11-15 14:13 ` Mark Brown
2011-11-15 14:13 ` Mark Brown
2011-11-16 12:56 ` Daniel Mack
2011-11-16 12:56 ` Daniel Mack
2011-11-16 13:19 ` Mark Brown
2011-11-16 13:19 ` Mark Brown
2011-11-16 14:06 ` Daniel Mack
2011-11-16 14:06 ` Daniel Mack
2011-11-16 14:11 ` Mark Brown
2011-11-16 14:11 ` Mark Brown
2011-11-16 14:19 ` Daniel Mack [this message]
2011-11-16 14:19 ` Daniel Mack
2011-11-16 15:07 ` Johannes Stezenbach
2011-11-16 15:07 ` [alsa-devel] " Johannes Stezenbach
2011-11-16 16:07 ` Mark Brown
2011-11-16 16:07 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC3C655.6000100@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.