From: Daniel Golle <dgolle@allnet.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH v0 3/6] support for antenna configuration profiles
Date: Wed, 16 Nov 2011 15:29:28 +0100 [thread overview]
Message-ID: <4EC3C8C8.7080706@allnet.de> (raw)
In-Reply-To: <CAJ-VmonAe-mKHvp_Ry1ZfSBTTHrbkcvfguzVx1XeSuOd8mWX6w@mail.gmail.com>
On 11/14/2011 03:44 PM, Adrian Chadd wrote
> I'd personally suggest not overriding the pModal EEPROM entry with
> your currently configured antenna profile.
> You have a perfectly good accessor method, why not use that?
As far as I can see the value stored in pModal->antCtrlCommon isn't actually
used anywhere besides in ath9k_hw_4k_set_board_values, which is only called once
during the init on module load. So not changing it at all and only setting the
AR_PHY_SWITCH_COM register should be fine. Agree?
next prev parent reply other threads:[~2011-11-16 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 13:03 [ath9k-devel] [PATCH v0 3/6] support for antenna configuration profiles Daniel Golle
2011-11-14 14:44 ` Adrian Chadd
2011-11-16 14:29 ` Daniel Golle [this message]
2011-11-16 16:36 ` Adrian Chadd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC3C8C8.7080706@allnet.de \
--to=dgolle@allnet.de \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.