From: Jon Hunter <jon-hunter@ti.com>
To: Govindraj <govindraj.ti@gmail.com>
Cc: "Govindraj.R" <govindraj.raja@ti.com>,
linux-omap@vger.kernel.org, Kevin Hilman <khilman@ti.com>,
Tony Lindgren <tony@atomide.com>, Rajendra Nayak <rnayak@ti.com>,
Partha Basak <p-basak2@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-serial@vger.kernel.org,
Vishwanath Sripathy <vishwanath.bs@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 11/20] OMAP2+: UART: Move errata handling from serial.c to omap-serial
Date: Wed, 16 Nov 2011 14:04:12 -0600 [thread overview]
Message-ID: <4EC4173C.7090200@ti.com> (raw)
In-Reply-To: <CAAL8m4xYUd=5g7VOa7Ofnm6nRs8U1a7W+sofAkeCVOOURRfVXg@mail.gmail.com>
Hi Govindraj,
On 11/16/2011 4:13, Govindraj wrote:
> On Tue, Nov 15, 2011 at 1:20 AM, Jon Hunter<jon-hunter@ti.com> wrote:
>> Hi Govindraj,
>
> [...]
>
>>>
>>> oh = uart->oh;
>>> - uart->dma_enabled = 0;
>>> name = DRIVER_NAME;
>>>
>>> omap_up.dma_enabled = uart->dma_enabled;
>>> omap_up.uartclk = OMAP24XX_BASE_BAUD * 16;
>>> omap_up.flags = UPF_BOOT_AUTOCONF;
>>> omap_up.get_context_loss_count =
>>> omap_pm_get_dev_context_loss_count;
>>> + omap_up.set_forceidle = omap_uart_set_forceidle;
>>> + omap_up.set_noidle = omap_uart_set_noidle;
>>> +
>>> + /* Enable the MDR1 errata for OMAP2/3/4 */
>>> + if ((cpu_is_omap2430() || cpu_is_omap34xx() ||
>>> cpu_is_omap44xx())&&
>>> + !cpu_is_ti816x())
>>> + omap_up.errata |= UART_ERRATA_i202_MDR1_ACCESS;
>>
>> I am not sure that this will apply the errata for OMAP3630 devices. I think
>> we need cpu_is_omap36xx() above too. Or you may wish to do
>> !cpu_class_is_omap1 and !cpu_is_omap2420.
>>
>
> Yes correct, I have updated this patch as here [1].
Thanks! Looks good.
> btw, omap-serial is applicable only for omap2+ so
> I think cpu_class_is omap1 not applicable here
> need to be handled in /mach-omap1/serial.c.
Duh! I missed that. We are good then.
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 11/20] OMAP2+: UART: Move errata handling from serial.c to omap-serial
Date: Wed, 16 Nov 2011 14:04:12 -0600 [thread overview]
Message-ID: <4EC4173C.7090200@ti.com> (raw)
In-Reply-To: <CAAL8m4xYUd=5g7VOa7Ofnm6nRs8U1a7W+sofAkeCVOOURRfVXg@mail.gmail.com>
Hi Govindraj,
On 11/16/2011 4:13, Govindraj wrote:
> On Tue, Nov 15, 2011 at 1:20 AM, Jon Hunter<jon-hunter@ti.com> wrote:
>> Hi Govindraj,
>
> [...]
>
>>>
>>> oh = uart->oh;
>>> - uart->dma_enabled = 0;
>>> name = DRIVER_NAME;
>>>
>>> omap_up.dma_enabled = uart->dma_enabled;
>>> omap_up.uartclk = OMAP24XX_BASE_BAUD * 16;
>>> omap_up.flags = UPF_BOOT_AUTOCONF;
>>> omap_up.get_context_loss_count =
>>> omap_pm_get_dev_context_loss_count;
>>> + omap_up.set_forceidle = omap_uart_set_forceidle;
>>> + omap_up.set_noidle = omap_uart_set_noidle;
>>> +
>>> + /* Enable the MDR1 errata for OMAP2/3/4 */
>>> + if ((cpu_is_omap2430() || cpu_is_omap34xx() ||
>>> cpu_is_omap44xx())&&
>>> + !cpu_is_ti816x())
>>> + omap_up.errata |= UART_ERRATA_i202_MDR1_ACCESS;
>>
>> I am not sure that this will apply the errata for OMAP3630 devices. I think
>> we need cpu_is_omap36xx() above too. Or you may wish to do
>> !cpu_class_is_omap1 and !cpu_is_omap2420.
>>
>
> Yes correct, I have updated this patch as here [1].
Thanks! Looks good.
> btw, omap-serial is applicable only for omap2+ so
> I think cpu_class_is omap1 not applicable here
> need to be handled in /mach-omap1/serial.c.
Duh! I missed that. We are good then.
Cheers
Jon
next prev parent reply other threads:[~2011-11-16 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 9:59 [PATCH v8 10/20] OMAP2+: UART: Get context loss count to context restore Govindraj.R
2011-11-11 9:59 ` Govindraj.R
2011-11-11 9:59 ` [PATCH v8 11/20] OMAP2+: UART: Move errata handling from serial.c to omap-serial Govindraj.R
2011-11-11 9:59 ` Govindraj.R
2011-11-14 19:50 ` Jon Hunter
2011-11-14 19:50 ` Jon Hunter
2011-11-16 10:13 ` Govindraj
2011-11-16 10:13 ` Govindraj
2011-11-16 20:04 ` Jon Hunter [this message]
2011-11-16 20:04 ` Jon Hunter
2011-11-11 9:59 ` [PATCH v8 12/20] OMAP2+: UART: Add wakeup mechanism for omap-uarts Govindraj.R
2011-11-11 9:59 ` Govindraj.R
2011-11-11 9:59 ` [PATCH v8 13/20] OMAP2+: UART: Remove old and unused clocks handling funcs Govindraj.R
2011-11-11 9:59 ` Govindraj.R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC4173C.7090200@ti.com \
--to=jon-hunter@ti.com \
--cc=govindraj.raja@ti.com \
--cc=govindraj.ti@gmail.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=p-basak2@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.