From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/5] ARM: davinci: create new common platform header for davinci
Date: Thu, 17 Nov 2011 14:48:17 +0400 [thread overview]
Message-ID: <4EC4E671.8030105@mvista.com> (raw)
In-Reply-To: <1321525138-3928-5-git-send-email-manjunath.hadli@ti.com>
Hello.
On 17-11-2011 14:18, Manjunath Hadli wrote:
> remove the code from individual platform header files for
> dm365, dm355, dm644x and dm646x and consolidate it into a
> single and common header file davinci_common.h.
> Include the new header file in individual platform header
> files as a pre-cursor for deleting these headers in follow
> up patches.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
[...]
> diff --git a/arch/arm/mach-davinci/include/mach/davinci.h b/arch/arm/mach-davinci/include/mach/davinci.h
> new file mode 100644
> index 0000000..49bf2f3
> --- /dev/null
> +++ b/arch/arm/mach-davinci/include/mach/davinci.h
> @@ -0,0 +1,88 @@
[...]
> +/* DM355 base addresses */
> +#define DM355_ASYNC_EMIF_CONTROL_BASE 0x01e10000
> +#define DM355_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> +/* DM365 base addresses */
> +#define DM365_ASYNC_EMIF_CONTROL_BASE 0x01d10000
> +#define DM365_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> +#define DM365_ASYNC_EMIF_DATA_CE1_BASE 0x04000000
Note that DM355/365 EMIF CE0/1 bases are similar -- perhaps it's worth to
have the single definition for them now, like DM3X5_ASYNC_EMIF_DATA_CE<n>_BASE.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: LMML <linux-media@vger.kernel.org>,
dlos <davinci-linux-open-source@linux.davincidsp.com>,
LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/5] ARM: davinci: create new common platform header for davinci
Date: Thu, 17 Nov 2011 14:48:17 +0400 [thread overview]
Message-ID: <4EC4E671.8030105@mvista.com> (raw)
In-Reply-To: <1321525138-3928-5-git-send-email-manjunath.hadli@ti.com>
Hello.
On 17-11-2011 14:18, Manjunath Hadli wrote:
> remove the code from individual platform header files for
> dm365, dm355, dm644x and dm646x and consolidate it into a
> single and common header file davinci_common.h.
> Include the new header file in individual platform header
> files as a pre-cursor for deleting these headers in follow
> up patches.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
[...]
> diff --git a/arch/arm/mach-davinci/include/mach/davinci.h b/arch/arm/mach-davinci/include/mach/davinci.h
> new file mode 100644
> index 0000000..49bf2f3
> --- /dev/null
> +++ b/arch/arm/mach-davinci/include/mach/davinci.h
> @@ -0,0 +1,88 @@
[...]
> +/* DM355 base addresses */
> +#define DM355_ASYNC_EMIF_CONTROL_BASE 0x01e10000
> +#define DM355_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> +/* DM365 base addresses */
> +#define DM365_ASYNC_EMIF_CONTROL_BASE 0x01d10000
> +#define DM365_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> +#define DM365_ASYNC_EMIF_DATA_CE1_BASE 0x04000000
Note that DM355/365 EMIF CE0/1 bases are similar -- perhaps it's worth to
have the single definition for them now, like DM3X5_ASYNC_EMIF_DATA_CE<n>_BASE.
WBR, Sergei
next prev parent reply other threads:[~2011-11-17 10:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 10:18 [PATCH v3 0/5] ARM: davinci: re-arrange definitions to have a common davinci header Manjunath Hadli
2011-11-17 10:18 ` Manjunath Hadli
2011-11-17 10:18 ` [PATCH v3 1/5] ARM: davinci: dm644x: remove the macros from the header to move to c file Manjunath Hadli
2011-11-17 10:18 ` Manjunath Hadli
2011-11-17 10:18 ` [PATCH v3 2/5] ARM: davinci: dm365: " Manjunath Hadli
2011-11-17 10:18 ` Manjunath Hadli
2011-11-17 10:18 ` [PATCH v3 3/5] ARM: davinci: dm646x: " Manjunath Hadli
2011-11-17 10:18 ` Manjunath Hadli
2011-11-17 10:18 ` [PATCH v3 4/5] ARM: davinci: create new common platform header for davinci Manjunath Hadli
2011-11-17 10:18 ` Manjunath Hadli
2011-11-17 10:35 ` Sergei Shtylyov
2011-11-17 10:35 ` Sergei Shtylyov
2011-11-17 10:48 ` Sergei Shtylyov [this message]
2011-11-17 10:48 ` Sergei Shtylyov
2011-11-17 10:59 ` Hadli, Manjunath
2011-11-17 10:59 ` Hadli, Manjunath
2011-11-17 10:18 ` [PATCH v3 5/5] ARM: davinci: delete individual platform header files and use a common header Manjunath Hadli
2011-11-17 10:18 ` Manjunath Hadli
2011-11-17 10:38 ` Sergei Shtylyov
2011-11-17 10:38 ` Sergei Shtylyov
2011-11-30 11:37 ` [PATCH v3 0/5] ARM: davinci: re-arrange definitions to have a common davinci header Nori, Sekhar
2011-11-30 11:37 ` Nori, Sekhar
2011-12-02 6:29 ` Hadli, Manjunath
2011-12-02 6:29 ` Hadli, Manjunath
2011-12-02 12:42 ` Nori, Sekhar
2011-12-02 12:42 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC4E671.8030105@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.