* [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC dependency
@ 2011-11-17 18:36 Vivien Didelot
2011-11-17 18:39 ` H. Peter Anvin
0 siblings, 1 reply; 4+ messages in thread
From: Vivien Didelot @ 2011-11-17 18:36 UTC (permalink / raw)
To: x86
Cc: Vivien Didelot, Ingo Molnar, Thomas Gleixner, H. Peter Anvin,
linux-kernel
Hi Ingo,
Here's the fix for the Kconfig dependency issue, for the TS-5500 platform.
It is based on the latest x86/platform branch from the -tip tree.
Best,
Vivien
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
arch/x86/platform/ts5500/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/ts5500/Kconfig b/arch/x86/platform/ts5500/Kconfig
index be51b86..84e59a9 100644
--- a/arch/x86/platform/ts5500/Kconfig
+++ b/arch/x86/platform/ts5500/Kconfig
@@ -23,6 +23,6 @@ config TS5500_LED
config TS5500_ADC
bool "TS-5500 ADC"
- depends on TS5500
+ depends on TS5500 && HWMON=y
help
Support for the A/D converter on Technologic Systems TS-5500 SBCs.
--
1.7.6.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC dependency
2011-11-17 18:36 [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC dependency Vivien Didelot
@ 2011-11-17 18:39 ` H. Peter Anvin
2011-11-17 18:57 ` Vivien Didelot
0 siblings, 1 reply; 4+ messages in thread
From: H. Peter Anvin @ 2011-11-17 18:39 UTC (permalink / raw)
To: Vivien Didelot; +Cc: x86, Ingo Molnar, Thomas Gleixner, linux-kernel
On 11/17/2011 10:36 AM, Vivien Didelot wrote:
> Hi Ingo,
>
> Here's the fix for the Kconfig dependency issue, for the TS-5500 platform.
> It is based on the latest x86/platform branch from the -tip tree.
>
> Best,
>
> Vivien
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
> arch/x86/platform/ts5500/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/platform/ts5500/Kconfig b/arch/x86/platform/ts5500/Kconfig
> index be51b86..84e59a9 100644
> --- a/arch/x86/platform/ts5500/Kconfig
> +++ b/arch/x86/platform/ts5500/Kconfig
> @@ -23,6 +23,6 @@ config TS5500_LED
>
> config TS5500_ADC
> bool "TS-5500 ADC"
> - depends on TS5500
> + depends on TS5500 && HWMON=y
> help
> Support for the A/D converter on Technologic Systems TS-5500 SBCs.
Shouldn't this be a module, too?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC dependency
2011-11-17 18:39 ` H. Peter Anvin
@ 2011-11-17 18:57 ` Vivien Didelot
2011-11-17 19:29 ` H. Peter Anvin
0 siblings, 1 reply; 4+ messages in thread
From: Vivien Didelot @ 2011-11-17 18:57 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: x86, Ingo Molnar, Thomas Gleixner, linux-kernel
On Thu, 17 Nov 2011 10:39:06 -0800,
"H. Peter Anvin" <hpa@zytor.com> wrote:
> On 11/17/2011 10:36 AM, Vivien Didelot wrote:
> > Hi Ingo,
> >
> > Here's the fix for the Kconfig dependency issue, for the TS-5500
> > platform. It is based on the latest x86/platform branch from the
> > -tip tree.
> >
> > Best,
> >
> > Vivien
> >
> > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > ---
> > arch/x86/platform/ts5500/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/platform/ts5500/Kconfig
> > b/arch/x86/platform/ts5500/Kconfig index be51b86..84e59a9 100644
> > --- a/arch/x86/platform/ts5500/Kconfig
> > +++ b/arch/x86/platform/ts5500/Kconfig
> > @@ -23,6 +23,6 @@ config TS5500_LED
> >
> > config TS5500_ADC
> > bool "TS-5500 ADC"
> > - depends on TS5500
> > + depends on TS5500 && HWMON=y
> > help
> > Support for the A/D converter on Technologic Systems TS-5500
> > SBCs.
>
> Shouldn't this be a module, too?
>
> -hpa
>
IMHO it would be overkill for such a small embedded platform to provide
device drivers as modules.
Regards,
Vivien
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC dependency
2011-11-17 18:57 ` Vivien Didelot
@ 2011-11-17 19:29 ` H. Peter Anvin
0 siblings, 0 replies; 4+ messages in thread
From: H. Peter Anvin @ 2011-11-17 19:29 UTC (permalink / raw)
To: Vivien Didelot; +Cc: x86, Ingo Molnar, Thomas Gleixner, linux-kernel
On 11/17/2011 10:57 AM, Vivien Didelot wrote:
>
> IMHO it would be overkill for such a small embedded platform to provide
> device drivers as modules.
>
You have it exactly backwards. It should be possible to have these
drivers available in a generic kernel without burdening all systems in
the world.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-17 19:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-17 18:36 [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC dependency Vivien Didelot
2011-11-17 18:39 ` H. Peter Anvin
2011-11-17 18:57 ` Vivien Didelot
2011-11-17 19:29 ` H. Peter Anvin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.