From: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Tejun Heo <htejun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Tomasz Buchert <tomasz.buchert-MZpvjPyXg2s@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Paul Menage <paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org>
Subject: Re: [PATCH] cgroup_freezer: fix freezing groups with stopped tasks
Date: Tue, 22 Nov 2011 10:20:02 +0800 [thread overview]
Message-ID: <4ECB06D2.6060106@cn.fujitsu.com> (raw)
In-Reply-To: <20111121230709.GR25776-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Tejun Heo wrote:
> Hello, Michal.
>
> On Wed, Nov 16, 2011 at 10:50:34PM +0100, Michal Hocko wrote:
>> +/* Task is frozen or will freeze immediately when next it gets woken */
>> +static bool is_task_frozen_enough(struct task_struct *task)
>> +{
>> + return frozen(task) ||
>> + (task_is_stopped_or_traced(task) && freezing(task));
>> +}
>
> Hmmm... w/ pending freezer updates, the above would always return
> %true if there's freezing in progress, which can't be right. Maybe
Only if the task is stopped/trace.
If we try to freeze a stopped task, it will be kept in freezing state.
> just test stopped/traced?
>
This can trigger a BUG_ON in update_if_frozen(), because we always count a
stopped task as frozen.
> http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=refs/heads/pm-freezer
>
> Thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Michal Hocko <mhocko@suse.cz>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
containers@lists.linux-foundation.org,
Tomasz Buchert <tomasz.buchert@inria.fr>,
Paul Menage <paul@paulmenage.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] cgroup_freezer: fix freezing groups with stopped tasks
Date: Tue, 22 Nov 2011 10:20:02 +0800 [thread overview]
Message-ID: <4ECB06D2.6060106@cn.fujitsu.com> (raw)
In-Reply-To: <20111121230709.GR25776@google.com>
Tejun Heo wrote:
> Hello, Michal.
>
> On Wed, Nov 16, 2011 at 10:50:34PM +0100, Michal Hocko wrote:
>> +/* Task is frozen or will freeze immediately when next it gets woken */
>> +static bool is_task_frozen_enough(struct task_struct *task)
>> +{
>> + return frozen(task) ||
>> + (task_is_stopped_or_traced(task) && freezing(task));
>> +}
>
> Hmmm... w/ pending freezer updates, the above would always return
> %true if there's freezing in progress, which can't be right. Maybe
Only if the task is stopped/trace.
If we try to freeze a stopped task, it will be kept in freezing state.
> just test stopped/traced?
>
This can trigger a BUG_ON in update_if_frozen(), because we always count a
stopped task as frozen.
> http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=refs/heads/pm-freezer
>
> Thanks.
>
next prev parent reply other threads:[~2011-11-22 2:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 21:50 [PATCH] cgroup_freezer: fix freezing groups with stopped tasks Michal Hocko
2011-11-16 21:50 ` Michal Hocko
[not found] ` <1321480234-29241-1-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org>
2011-11-17 10:14 ` Tomasz Buchert
[not found] ` <4EC4DE9D.3040703-MZpvjPyXg2s@public.gmane.org>
2011-11-17 16:13 ` Michal Hocko
2011-11-17 16:13 ` Michal Hocko
2011-11-17 16:13 ` Michal Hocko
[not found] ` <20111117161318.GA1233-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2011-11-17 17:03 ` Tomasz Buchert
2011-11-17 17:03 ` Tomasz Buchert
2011-11-17 17:03 ` Tomasz Buchert
2011-11-21 13:40 ` Michal Hocko
2011-11-21 13:40 ` Michal Hocko
2011-11-21 13:40 ` Michal Hocko
2011-11-21 23:07 ` Tejun Heo
2011-11-21 23:07 ` Tejun Heo
2011-11-21 23:07 ` Tejun Heo
[not found] ` <20111121230709.GR25776-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-11-22 2:20 ` Li Zefan [this message]
2011-11-22 2:20 ` Li Zefan
[not found] ` <4ECB06D2.6060106-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2011-11-22 2:21 ` Tejun Heo
2011-11-22 2:21 ` Tejun Heo
[not found] ` <20111122022118.GT25776-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-11-22 9:05 ` Michal Hocko
2011-11-22 9:05 ` Michal Hocko
[not found] ` <20111122090522.GA26768-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2011-11-22 15:39 ` Tejun Heo
2011-11-22 15:39 ` Tejun Heo
[not found] ` <20111122153948.GE322-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-11-22 15:48 ` Tejun Heo
2011-11-22 15:48 ` Tejun Heo
[not found] ` <20111122154748.GF322-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-11-23 2:00 ` Li Zefan
2011-11-23 2:00 ` Li Zefan
2011-11-24 10:04 ` Michal Hocko
2011-11-24 10:04 ` Michal Hocko
2011-11-24 10:04 ` Michal Hocko
[not found] ` <20111124100454.GE26036-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2011-11-24 20:00 ` Tejun Heo
2011-11-24 20:00 ` Tejun Heo
2011-11-24 20:00 ` Tejun Heo
[not found] ` <20111124200009.GB6735-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2011-11-24 21:52 ` Michal Hocko
2011-11-24 21:52 ` Michal Hocko
2011-11-24 21:52 ` Michal Hocko
2011-11-22 15:48 ` Tejun Heo
2011-11-22 15:56 ` Michal Hocko
2011-11-22 15:56 ` Michal Hocko
2011-11-22 15:56 ` Michal Hocko
2011-11-22 15:39 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2011-11-16 21:50 Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB06D2.6060106@cn.fujitsu.com \
--to=lizf-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=htejun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org \
--cc=tomasz.buchert-MZpvjPyXg2s@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.