From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET
Date: Tue, 22 Nov 2011 13:39:04 +0100 [thread overview]
Message-ID: <4ECB97E8.9040705@metafoo.de> (raw)
In-Reply-To: <1321926411.4764.1.camel@phoenix>
On 11/22/2011 02:46 AM, Axel Lin wrote:
> According to the datasheet:
> The BIT[5:4] of ADC Control Register 2 is to control the word width.
> 00 = 25 Bits
> 01 = 20 Bits
> 10 = 16 Bits
> 11 = Invalid
>
> Thus, the AD1836_ADC_WORD_OFFSET should be defined as 4.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
> ---
> sound/soc/codecs/ad1836.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/ad1836.h b/sound/soc/codecs/ad1836.h
> index 444747f..dd7be0d 100644
> --- a/sound/soc/codecs/ad1836.h
> +++ b/sound/soc/codecs/ad1836.h
> @@ -34,7 +34,7 @@
>
> #define AD1836_ADC_CTRL2 13
> #define AD1836_ADC_WORD_LEN_MASK 0x30
> -#define AD1836_ADC_WORD_OFFSET 5
> +#define AD1836_ADC_WORD_OFFSET 4
> #define AD1836_ADC_SERFMT_MASK (7 << 6)
> #define AD1836_ADC_SERFMT_PCK256 (0x4 << 6)
> #define AD1836_ADC_SERFMT_PCK128 (0x5 << 6)
next prev parent reply other threads:[~2011-11-22 12:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 1:46 [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET Axel Lin
2011-11-22 12:39 ` Lars-Peter Clausen [this message]
2011-11-22 13:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECB97E8.9040705@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.