* [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET
@ 2011-11-22 1:46 Axel Lin
2011-11-22 12:39 ` Lars-Peter Clausen
2011-11-22 13:00 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-11-22 1:46 UTC (permalink / raw)
To: alsa-devel; +Cc: Lars-Peter Clausen, Brown, Liam Girdwood, Mark
According to the datasheet:
The BIT[5:4] of ADC Control Register 2 is to control the word width.
00 = 25 Bits
01 = 20 Bits
10 = 16 Bits
11 = Invalid
Thus, the AD1836_ADC_WORD_OFFSET should be defined as 4.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/ad1836.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/ad1836.h b/sound/soc/codecs/ad1836.h
index 444747f..dd7be0d 100644
--- a/sound/soc/codecs/ad1836.h
+++ b/sound/soc/codecs/ad1836.h
@@ -34,7 +34,7 @@
#define AD1836_ADC_CTRL2 13
#define AD1836_ADC_WORD_LEN_MASK 0x30
-#define AD1836_ADC_WORD_OFFSET 5
+#define AD1836_ADC_WORD_OFFSET 4
#define AD1836_ADC_SERFMT_MASK (7 << 6)
#define AD1836_ADC_SERFMT_PCK256 (0x4 << 6)
#define AD1836_ADC_SERFMT_PCK128 (0x5 << 6)
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET
2011-11-22 1:46 [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET Axel Lin
@ 2011-11-22 12:39 ` Lars-Peter Clausen
2011-11-22 13:00 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2011-11-22 12:39 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, Liam Girdwood
On 11/22/2011 02:46 AM, Axel Lin wrote:
> According to the datasheet:
> The BIT[5:4] of ADC Control Register 2 is to control the word width.
> 00 = 25 Bits
> 01 = 20 Bits
> 10 = 16 Bits
> 11 = Invalid
>
> Thus, the AD1836_ADC_WORD_OFFSET should be defined as 4.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
> ---
> sound/soc/codecs/ad1836.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/ad1836.h b/sound/soc/codecs/ad1836.h
> index 444747f..dd7be0d 100644
> --- a/sound/soc/codecs/ad1836.h
> +++ b/sound/soc/codecs/ad1836.h
> @@ -34,7 +34,7 @@
>
> #define AD1836_ADC_CTRL2 13
> #define AD1836_ADC_WORD_LEN_MASK 0x30
> -#define AD1836_ADC_WORD_OFFSET 5
> +#define AD1836_ADC_WORD_OFFSET 4
> #define AD1836_ADC_SERFMT_MASK (7 << 6)
> #define AD1836_ADC_SERFMT_PCK256 (0x4 << 6)
> #define AD1836_ADC_SERFMT_PCK128 (0x5 << 6)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET
2011-11-22 1:46 [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET Axel Lin
2011-11-22 12:39 ` Lars-Peter Clausen
@ 2011-11-22 13:00 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-11-22 13:00 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Lars-Peter Clausen, Liam Girdwood, Mark
On Tue, Nov 22, 2011 at 09:46:51AM +0800, Axel Lin wrote:
> According to the datasheet:
> The BIT[5:4] of ADC Control Register 2 is to control the word width.
> 00 = 25 Bits
> 01 = 20 Bits
> 10 = 16 Bits
> 11 = Invalid
>
> Thus, the AD1836_ADC_WORD_OFFSET should be defined as 4.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-22 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 1:46 [PATCH] ASoC: Fix wrong define for AD1836_ADC_WORD_OFFSET Axel Lin
2011-11-22 12:39 ` Lars-Peter Clausen
2011-11-22 13:00 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.