From: Timur Tabi <timur@freescale.com>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Sven Neumann <s.neumann@raumfeld.com>,
lrg@ti.com
Subject: Re: [PATCH] ALSA: ASoC: cs4720: use snd_soc_cache_sync()
Date: Tue, 22 Nov 2011 09:47:41 -0600 [thread overview]
Message-ID: <4ECBC41D.4000904@freescale.com> (raw)
In-Reply-To: <4ECBC367.8080801@gmail.com>
Daniel Mack wrote:
> The code is so simple that I'm starting to suspect
> i2c_smbus_write_byte_data() is doing something very wrong, but I can't
> trace it without a hardware I2C analyzer right now. The i2c-regmap
> low-level implementation uses different access functions under the hood,
> so maybe that's a regression.
What platform are you testing this on? I never really understood the i2c vs. smbus thing (I can never tell which function an i2c device really needs), so I only know that the i2c code works on my PowerPC board.
Also keep in mind that a patch that affects i2c_smbus_write_byte_data() on PowerPC was recently posted, but not approved yet. Check the thread, "i2c/busses: (mpc) Add support for SMBUS_READ_BLOCK_DATA".
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2011-11-22 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:45 [PATCH] ALSA: ASoC: cs4720: use snd_soc_cache_sync() Daniel Mack
2011-11-22 14:02 ` Mark Brown
2011-11-22 15:23 ` Daniel Mack
2011-11-22 15:35 ` Mark Brown
2011-11-22 15:37 ` Timur Tabi
2011-11-22 15:41 ` Daniel Mack
2011-11-22 15:43 ` Mark Brown
2011-11-22 15:44 ` Daniel Mack
2011-11-22 15:47 ` Timur Tabi [this message]
2011-11-22 15:57 ` Daniel Mack
2011-11-22 16:12 ` Timur Tabi
2011-11-22 15:53 ` Mark Brown
2011-11-22 16:04 ` Daniel Mack
2011-11-22 16:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECBC41D.4000904@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=s.neumann@raumfeld.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.