* [RFC PATCH 0/1] Can we drop Clutter bbappends?
@ 2011-11-16 0:16 Joshua Lock
2011-11-16 0:16 ` [RFC PATCH 1/1] clutter: drop unneeded bbappends Joshua Lock
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Joshua Lock @ 2011-11-16 0:16 UTC (permalink / raw)
To: poky
All,
The subject says it all. My reading of recent changes in oe-core around X and
clutter lead me to believe that our bbappend is redundant so I'm proposing we
drop it.
Both virtual/libgl being in DEPENDS and passing the --with-flavour=glx option
are part of the standard clutter.inc now.
I may well be wrong but I like patches as a way to start discussion.
Cheers,
Joshua
Please review the following changes for suitability for inclusion. If you have
any objections or suggestions for improvement, please respond to the patches. If
you agree with the changes, please provide your Acked-by.
The following changes since commit fa81f8dfb7a342e355b608aa4204cf23ed2b251c:
mime.bbclass: fix typo (2011-11-15 12:05:30 +0000)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib josh/work
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=josh/work
Joshua Lock (1):
clutter: drop unneeded bbappends
.../clutter/clutter-1.6_1.6.18.bbappend | 4 ----
.../clutter/clutter-1.8_1.8.0.bbappend | 4 ----
.../recipes-graphics/clutter/clutter_git.bbappend | 4 ----
3 files changed, 0 insertions(+), 12 deletions(-)
delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
--
1.7.7.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [RFC PATCH 1/1] clutter: drop unneeded bbappends
2011-11-16 0:16 [RFC PATCH 0/1] Can we drop Clutter bbappends? Joshua Lock
@ 2011-11-16 0:16 ` Joshua Lock
2011-11-22 11:28 ` Richard Purdie
2011-11-21 18:47 ` [RFC PATCH 0/1] Can we drop Clutter bbappends? Joshua Lock
2011-11-30 15:46 ` Richard Purdie
2 siblings, 1 reply; 6+ messages in thread
From: Joshua Lock @ 2011-11-16 0:16 UTC (permalink / raw)
To: poky
The --with-flavour-glx option is the default in clutter.inc now
Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
.../clutter/clutter-1.6_1.6.18.bbappend | 4 ----
.../clutter/clutter-1.8_1.8.0.bbappend | 4 ----
.../recipes-graphics/clutter/clutter_git.bbappend | 4 ----
3 files changed, 0 insertions(+), 12 deletions(-)
delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
diff --git a/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend b/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
deleted file mode 100644
index c7cc683..0000000
--- a/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
+++ /dev/null
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
-
diff --git a/meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend b/meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
deleted file mode 100644
index c7cc683..0000000
--- a/meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
+++ /dev/null
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
-
diff --git a/meta-yocto/recipes-graphics/clutter/clutter_git.bbappend b/meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
deleted file mode 100644
index c7cc683..0000000
--- a/meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
+++ /dev/null
@@ -1,4 +0,0 @@
-DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
-EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
-PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
-
--
1.7.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RFC PATCH 1/1] clutter: drop unneeded bbappends
2011-11-16 0:16 ` [RFC PATCH 1/1] clutter: drop unneeded bbappends Joshua Lock
@ 2011-11-22 11:28 ` Richard Purdie
2011-11-22 21:44 ` Joshua Lock
0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2011-11-22 11:28 UTC (permalink / raw)
To: Joshua Lock; +Cc: poky
On Tue, 2011-11-15 at 16:16 -0800, Joshua Lock wrote:
> The --with-flavour-glx option is the default in clutter.inc now
>
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
> .../clutter/clutter-1.6_1.6.18.bbappend | 4 ----
> .../clutter/clutter-1.8_1.8.0.bbappend | 4 ----
> .../recipes-graphics/clutter/clutter_git.bbappend | 4 ----
> 3 files changed, 0 insertions(+), 12 deletions(-)
> delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
> delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
> delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
>
> diff --git a/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend b/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
> deleted file mode 100644
> index c7cc683..0000000
> --- a/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
> -EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
> -PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
I'm fine with this but one question - is the virtual/xserver dependency
still needed? If so we should add it to .inc. I'm in favour of merging
this patch though.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH 1/1] clutter: drop unneeded bbappends
2011-11-22 11:28 ` Richard Purdie
@ 2011-11-22 21:44 ` Joshua Lock
0 siblings, 0 replies; 6+ messages in thread
From: Joshua Lock @ 2011-11-22 21:44 UTC (permalink / raw)
To: Richard Purdie; +Cc: poky
On 22/11/11 03:28, Richard Purdie wrote:
> On Tue, 2011-11-15 at 16:16 -0800, Joshua Lock wrote:
>> The --with-flavour-glx option is the default in clutter.inc now
>>
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>> ---
>> .../clutter/clutter-1.6_1.6.18.bbappend | 4 ----
>> .../clutter/clutter-1.8_1.8.0.bbappend | 4 ----
>> .../recipes-graphics/clutter/clutter_git.bbappend | 4 ----
>> 3 files changed, 0 insertions(+), 12 deletions(-)
>> delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
>> delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter-1.8_1.8.0.bbappend
>> delete mode 100644 meta-yocto/recipes-graphics/clutter/clutter_git.bbappend
>>
>> diff --git a/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend b/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
>> deleted file mode 100644
>> index c7cc683..0000000
>> --- a/meta-yocto/recipes-graphics/clutter/clutter-1.6_1.6.18.bbappend
>> +++ /dev/null
>> @@ -1,4 +0,0 @@
>> -DEPENDS_atom-pc = "${STDDEPENDS} virtual/xserver-xf86 virtual/libgl"
>> -EXTRA_OECONF_atom-pc = "${BASE_CONF} --with-flavour=glx"
>> -PACKAGE_ARCH_atom-pc = "${MACHINE_ARCH}"
>
>
> I'm fine with this but one question - is the virtual/xserver dependency
> still needed? If so we should add it to .inc. I'm in favour of merging
> this patch though.
My git fu is failing me so I've not been able to work out why
virtual/xserver was added to the DEPENDS for atom-pc. I suspect it's not
needed, though - I've been able to build clutter-1.8 for atom-pc in a
clean TMPDIR without virtual/xserver in DEPENDS (though I have found a
fix for cogl - expect it soon).
Cheers,
Joshua
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 0/1] Can we drop Clutter bbappends?
2011-11-16 0:16 [RFC PATCH 0/1] Can we drop Clutter bbappends? Joshua Lock
2011-11-16 0:16 ` [RFC PATCH 1/1] clutter: drop unneeded bbappends Joshua Lock
@ 2011-11-21 18:47 ` Joshua Lock
2011-11-30 15:46 ` Richard Purdie
2 siblings, 0 replies; 6+ messages in thread
From: Joshua Lock @ 2011-11-21 18:47 UTC (permalink / raw)
To: poky
On 15/11/11 16:16, Joshua Lock wrote:
> All,
>
> The subject says it all. My reading of recent changes in oe-core around X and
> clutter lead me to believe that our bbappend is redundant so I'm proposing we
> drop it.
>
> Both virtual/libgl being in DEPENDS and passing the --with-flavour=glx option
> are part of the standard clutter.inc now.
>
> I may well be wrong but I like patches as a way to start discussion.
Any discusser's?
Cheers,
Joshua
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH 0/1] Can we drop Clutter bbappends?
2011-11-16 0:16 [RFC PATCH 0/1] Can we drop Clutter bbappends? Joshua Lock
2011-11-16 0:16 ` [RFC PATCH 1/1] clutter: drop unneeded bbappends Joshua Lock
2011-11-21 18:47 ` [RFC PATCH 0/1] Can we drop Clutter bbappends? Joshua Lock
@ 2011-11-30 15:46 ` Richard Purdie
2 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2011-11-30 15:46 UTC (permalink / raw)
To: Joshua Lock; +Cc: poky
On Tue, 2011-11-15 at 16:16 -0800, Joshua Lock wrote:
> All,
>
> The subject says it all. My reading of recent changes in oe-core around X and
> clutter lead me to believe that our bbappend is redundant so I'm proposing we
> drop it.
>
> Both virtual/libgl being in DEPENDS and passing the --with-flavour=glx option
> are part of the standard clutter.inc now.
>
> I may well be wrong but I like patches as a way to start discussion.
>
> Cheers,
> Joshua
>
> Please review the following changes for suitability for inclusion. If you have
> any objections or suggestions for improvement, please respond to the patches. If
> you agree with the changes, please provide your Acked-by.
>
> The following changes since commit fa81f8dfb7a342e355b608aa4204cf23ed2b251c:
>
> mime.bbclass: fix typo (2011-11-15 12:05:30 +0000)
>
> are available in the git repository at:
> git://git.yoctoproject.org/poky-contrib josh/work
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=josh/work
>
> Joshua Lock (1):
> clutter: drop unneeded bbappends
I've went ahead and merged this.
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-30 15:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 0:16 [RFC PATCH 0/1] Can we drop Clutter bbappends? Joshua Lock
2011-11-16 0:16 ` [RFC PATCH 1/1] clutter: drop unneeded bbappends Joshua Lock
2011-11-22 11:28 ` Richard Purdie
2011-11-22 21:44 ` Joshua Lock
2011-11-21 18:47 ` [RFC PATCH 0/1] Can we drop Clutter bbappends? Joshua Lock
2011-11-30 15:46 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.