All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Franky Lin" <frankyl@broadcom.com>
To: "Denis 'GNUtoo' Carikli" <GNUtoo@no-log.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: brcmfmac + compat wireless + 2.6.35
Date: Tue, 22 Nov 2011 14:16:33 -0800	[thread overview]
Message-ID: <4ECC1F41.90003@broadcom.com> (raw)
In-Reply-To: <201111222046.54310.GNUtoo@no-log.org>

Hi Denis,

On 11/22/2011 11:46 AM, Denis 'GNUtoo' Carikli wrote:
>   * adding an if 0 in brcmf_sdcard_intr_reg removes the problematic dmesg
> message:
> int brcmf_sdcard_intr_reg(struct brcmf_sdio_dev *sdiodev)
> {
>          brcmf_dbg(TRACE, "Entering\n");
> #if 0
>          sdio_claim_host(sdiodev->func[1]);
>          sdio_claim_irq(sdiodev->func[1], brcmf_sdioh_irqhandler);
>          sdio_release_host(sdiodev->func[1]);
> #endif
>          return 0;
> }
> but then:
> # ifconfig wlan0 up
> ifconfig: SIOCSIFFLAGS: Operation not permitted
> (with rfkill state ok (soft = 0, hard = 0, state = 1) and beeing root.

Root cause for the mmc complain is that there is no handler for function 
2 interrupt. 4329 generate a SDIO interrupt when there are something 
available for the driver to retrieve from the dongle. It will flag both 
function 1 and function 2 at the same time. They are identical. A empty 
dummy irq handler register to function 2 irq will make the warning go 
away. FWIW, it doesn't affect anything here since they have been taken 
care in function 1 irq handler. I will submit a patch too add the dummy 
handler.

Thanks,
Franky


  reply	other threads:[~2011-11-22 22:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 15:00 brcmfmac + compat wireless + 2.6.35 Denis 'GNUtoo' Carikli
2011-11-22 19:46 ` Denis 'GNUtoo' Carikli
2011-11-22 22:16   ` Franky Lin [this message]
2011-11-23 15:59     ` Denis 'GNUtoo' Carikli
2011-12-10 17:51     ` Denis 'GNUtoo' Carikli
2011-12-10 17:51       ` [PATCH] brcm80211: fmac: try to add a dummy interupt handler for sdio function 2 Denis 'GNUtoo' Carikli
2011-12-10 20:46       ` brcmfmac + compat wireless + 2.6.35 Franky Lin
2011-12-10 22:57         ` Denis 'GNUtoo' Carikli
2011-12-18 11:33         ` Denis 'GNUtoo' Carikli
2011-12-19 18:29           ` Franky Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECC1F41.90003@broadcom.com \
    --to=frankyl@broadcom.com \
    --cc=GNUtoo@no-log.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.