From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 16/18] ath9k: make ath_reset non-static
Date: Thu, 24 Nov 2011 11:37:33 +0530 [thread overview]
Message-ID: <4ECDDF25.6030900@qca.qualcomm.com> (raw)
In-Reply-To: <4ECD1224.3070900@openwrt.org>
On Wednesday 23 November 2011 09:02 PM, Felix Fietkau wrote:
> Doing reset from tasklet context created several nasty stability issues
> that were hard to track down, and the potential gain from doing reset
> 'immediately' that way is purely theoretical. Resets should be rare in
> normal operation, as they're also expensive.
> The main problem when running reset from a tasklet is that there is no
> way of gracefully shutting down ongoing workqueue activity, so the
> result of the reset could be that the work items mess up the state right
> after the reset is done.
thanks, true in this case ath_reset is called from tasklet context. i
will send a v2 for using queue_work.
>
> - Felix
--
thanks,
shafi
WARNING: multiple messages have this Message-ID (diff)
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Jouni Malinen <jouni@qca.qualcomm.com>,
<linux-wireless@vger.kernel.org>,
Rodriguez Luis <rodrigue@qca.qualcomm.com>,
Balasubramanian senthilkumar <senthilb@qca.qualcomm.com>,
Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>,
Rajkumar Manoharan <rmanohar@qca.qualcomm.com>,
Vivek Natarajan <nataraja@qca.qualcomm.com>,
<ath9k-devel@lists.ath9k.org>,
Wilson Tsao <wtsao@qca.qualcomm.com>
Subject: Re: [PATCH 16/18] ath9k: make ath_reset non-static
Date: Thu, 24 Nov 2011 11:37:33 +0530 [thread overview]
Message-ID: <4ECDDF25.6030900@qca.qualcomm.com> (raw)
In-Reply-To: <4ECD1224.3070900@openwrt.org>
On Wednesday 23 November 2011 09:02 PM, Felix Fietkau wrote:
> Doing reset from tasklet context created several nasty stability issues
> that were hard to track down, and the potential gain from doing reset
> 'immediately' that way is purely theoretical. Resets should be rare in
> normal operation, as they're also expensive.
> The main problem when running reset from a tasklet is that there is no
> way of gracefully shutting down ongoing workqueue activity, so the
> result of the reset could be that the work items mess up the state right
> after the reset is done.
thanks, true in this case ath_reset is called from tasklet context. i
will send a v2 for using queue_work.
>
> - Felix
--
thanks,
shafi
next prev parent reply other threads:[~2011-11-24 6:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 16:22 [ath9k-devel] [PATCH 00/18] Add support for MCI BT coex Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 01/18] ath9k_hw: add definitions to support MCI h/w code Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 02/18] ath9k_hw: add GPIO output MUX related macros Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 03/18] ath9k_hw: Add MCI h/w specific structure Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 04/18] ath9k_hw: initialize MCI parameters Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 05/18] ath9k_hw: Add MCI h/w code and state machine Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 06/18] ath9k: Add MCI interrupt to interrupt mask Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 07/18] ath9k_hw: take care of enabling MCI interrupts Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 08/18] ath9k_hw: check for asynchronous MCI interrupt pending Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 09/18] ath9k_hw: check for MCI interrupt in get_isr Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 10/18] ath9k: add MCI specific definitions and structures Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 11/18] ath9k: Add functions to allocate/free buffers for MCI Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 12/18] ath9k_hw: MCI related changes in chip management Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 13/18] ath9k_hw: MCI related changes in set_reset_reg Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 14/18] ath9k_hw: Add support for MCI WLAN calibration Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 15/18] ath9k_hw: Add MCI related changes in chip reset Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 16/18] ath9k: make ath_reset non-static Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-23 14:29 ` [ath9k-devel] " Felix Fietkau
2011-11-23 14:29 ` Felix Fietkau
2011-11-23 15:18 ` [ath9k-devel] " Mohammed Shafi Shajakhan
2011-11-23 15:18 ` Mohammed Shafi Shajakhan
2011-11-23 15:32 ` [ath9k-devel] " Felix Fietkau
2011-11-23 15:32 ` Felix Fietkau
2011-11-24 6:07 ` Mohammed Shafi Shajakhan [this message]
2011-11-24 6:07 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 17/18] ath9k: MCI state machine based on MCI interrupt Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
2011-11-22 16:22 ` [ath9k-devel] [PATCH 18/18] ath9k: fix a typo Mohammed Shafi Shajakhan
2011-11-22 16:22 ` Mohammed Shafi Shajakhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECDDF25.6030900@qca.qualcomm.com \
--to=mohammed@qca.qualcomm.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.