All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Asai Thambi S P <asamymuthupa@micron.com>,
	Sam Bradshaw <sbradshaw@micron.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtip32xx: uninitialized variable in mtip_quiesce_io()
Date: Thu, 24 Nov 2011 11:59:38 +0000	[thread overview]
Message-ID: <4ECE31AA.3020007@kernel.dk> (raw)
In-Reply-To: <20111124114702.GA32522@elgon.mountain>

On 2011-11-24 12:47, Dan Carpenter wrote:
> We recently introduce new continue in the loop which make gcc complain.
> In theory if MTIP_FLAG_SVC_THD_ACTIVE_BIT is set, we could hit continue
> over and over until eventually we time out of the loop.  In that case
> "active" should be set as true, but right now it's uninitialized.

Thanks Dan, applied.

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Asai Thambi S P <asamymuthupa@micron.com>,
	Sam Bradshaw <sbradshaw@micron.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtip32xx: uninitialized variable in mtip_quiesce_io()
Date: Thu, 24 Nov 2011 12:59:38 +0100	[thread overview]
Message-ID: <4ECE31AA.3020007@kernel.dk> (raw)
In-Reply-To: <20111124114702.GA32522@elgon.mountain>

On 2011-11-24 12:47, Dan Carpenter wrote:
> We recently introduce new continue in the loop which make gcc complain.
> In theory if MTIP_FLAG_SVC_THD_ACTIVE_BIT is set, we could hit continue
> over and over until eventually we time out of the loop.  In that case
> "active" should be set as true, but right now it's uninitialized.

Thanks Dan, applied.

-- 
Jens Axboe


  reply	other threads:[~2011-11-24 11:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24 11:47 [patch] mtip32xx: uninitialized variable in mtip_quiesce_io() Dan Carpenter
2011-11-24 11:47 ` Dan Carpenter
2011-11-24 11:59 ` Jens Axboe [this message]
2011-11-24 11:59   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ECE31AA.3020007@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=asamymuthupa@micron.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sbradshaw@micron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.