From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Patrice Vilchez <patrice.vilchez@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board
Date: Thu, 24 Nov 2011 16:26:02 +0100 [thread overview]
Message-ID: <4ECE620A.9050904@free-electrons.com> (raw)
In-Reply-To: <CAOMZO5ADJrLCV6ohkraohqJT1aD2hC_pWEsbDezWGchGrvRYvA@mail.gmail.com>
Hi,
On 24/11/2011 16:20, Fabio Estevam wrote:
> On Thu, Nov 24, 2011 at 9:27 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>
>> +static struct at91_adc_data ek_adc_data = {
>> + .channels_used = BIT(0) | BIT(1) | BIT(2) | BIT(3),
>> + .vref = 3300,
>> +};
>
> Don't you need to also pass adc_clock?
ADC Clock is SoC specific, while these variables are board-specific. It
is thus set in the file arch/arm/mach-at91/at91sam9260_devices.c, in the
same patch.
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board
Date: Thu, 24 Nov 2011 16:26:02 +0100 [thread overview]
Message-ID: <4ECE620A.9050904@free-electrons.com> (raw)
In-Reply-To: <CAOMZO5ADJrLCV6ohkraohqJT1aD2hC_pWEsbDezWGchGrvRYvA@mail.gmail.com>
Hi,
On 24/11/2011 16:20, Fabio Estevam wrote:
> On Thu, Nov 24, 2011 at 9:27 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
>
>> +static struct at91_adc_data ek_adc_data = {
>> + .channels_used = BIT(0) | BIT(1) | BIT(2) | BIT(3),
>> + .vref = 3300,
>> +};
>
> Don't you need to also pass adc_clock?
ADC Clock is SoC specific, while these variables are board-specific. It
is thus set in the file arch/arm/mach-at91/at91sam9260_devices.c, in the
same patch.
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-11-24 15:26 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 11:27 [PATCH v9] AT91: Add a driver for the ADC Maxime Ripard
2011-11-24 11:27 ` Maxime Ripard
2011-11-24 11:27 ` [PATCH 1/3] ARM: AT91: Add platform data for the ADCs Maxime Ripard
2011-11-24 11:27 ` Maxime Ripard
2011-11-24 14:29 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-24 14:29 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-24 11:27 ` [PATCH 2/3] ARM: AT91: IIO: Add AT91 ADC driver Maxime Ripard
2011-11-24 11:27 ` Maxime Ripard
2011-11-24 14:28 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-24 14:28 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-24 11:27 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-24 11:27 ` Maxime Ripard
2011-11-24 14:19 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-24 14:19 ` Jean-Christophe PLAGNIOL-VILLARD
2011-11-24 15:20 ` Fabio Estevam
2011-11-24 15:20 ` Fabio Estevam
2011-11-24 15:26 ` Maxime Ripard [this message]
2011-11-24 15:26 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2012-01-16 21:36 [PATCH RESEND v13] AT91: Add a driver for the ADC Maxime Ripard
2012-01-16 21:36 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2012-01-16 21:36 ` Maxime Ripard
2012-01-18 10:28 ` Nicolas Ferre
2012-01-18 10:28 ` Nicolas Ferre
2011-12-14 10:01 [PATCH v13] AT91: Add a driver for the ADC Maxime Ripard
2011-12-14 10:01 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-12-02 13:17 [PATCH v12] AT91: Add a driver for the ADC Maxime Ripard
2011-12-02 13:17 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-12-02 13:17 ` Maxime Ripard
2011-11-30 9:14 [PATCH v11] AT91: Add a driver for the ADC Maxime Ripard
2011-11-30 9:15 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-30 9:15 ` Maxime Ripard
2011-11-18 10:12 [PATCH v8] AT91: Add a driver for the ADC Maxime Ripard
2011-11-18 10:12 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-18 10:12 ` Maxime Ripard
2011-11-15 10:54 [PATCH v7] AT91: Add a driver for the ADC Maxime Ripard
2011-11-15 10:54 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-15 10:54 ` Maxime Ripard
2011-11-14 17:30 [PATCH v6] AT91: Add a driver for the ADC Maxime Ripard
2011-11-14 17:30 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-14 17:30 ` Maxime Ripard
2011-11-14 20:34 ` Jonathan Cameron
2011-11-14 20:34 ` Jonathan Cameron
2011-11-15 10:27 ` Maxime Ripard
2011-11-15 10:27 ` Maxime Ripard
2011-11-14 10:06 [PATCHv5] AT91: Add a driver for the ADC Maxime Ripard
2011-11-14 10:06 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-14 10:06 ` Maxime Ripard
2011-11-14 11:29 ` Nicolas Ferre
2011-11-14 11:29 ` Nicolas Ferre
2011-11-14 15:17 ` Maxime Ripard
2011-11-14 15:17 ` Maxime Ripard
2011-11-14 15:23 ` Nicolas Ferre
2011-11-14 15:23 ` Nicolas Ferre
2011-10-19 16:18 [PATCH] AT91: Add a driver for the ADC Maxime Ripard
2011-10-19 16:18 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-10-19 16:18 ` Maxime Ripard
2011-10-20 6:28 ` Alexander Stein
2011-10-20 6:28 ` Alexander Stein
2011-10-21 17:47 ` Maxime Ripard
2011-10-21 17:47 ` Maxime Ripard
2011-10-20 7:14 ` Thomas Petazzoni
2011-10-20 7:14 ` Thomas Petazzoni
2011-11-03 10:11 ` [PATCHv2] AT91: Add a driver for the ADC Maxime Ripard
2011-11-03 10:11 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-03 10:11 ` Maxime Ripard
2011-11-04 10:33 ` Jonathan Cameron
2011-11-04 10:33 ` Jonathan Cameron
2011-11-04 11:25 ` Maxime Ripard
2011-11-04 15:52 ` Linus Walleij
2011-11-04 16:32 ` Jonathan Cameron
2011-11-04 16:32 ` Jonathan Cameron
2011-11-07 16:08 ` [PATCHv3] AT91: Add a driver for the ADC Maxime Ripard
2011-11-07 16:08 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-07 16:08 ` Maxime Ripard
2011-11-09 10:19 ` [PATCHv4] AT91: Add a driver for the ADC Maxime Ripard
2011-11-09 10:19 ` [PATCH 3/3] ARM: AT91: Add the ADC to the sam9g20ek board Maxime Ripard
2011-11-09 10:19 ` Maxime Ripard
2011-11-10 17:37 ` Jonathan Cameron
2011-11-10 17:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECE620A.9050904@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=patrice.vilchez@atmel.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.