From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] ARM: omap3: added common configuration for Technexion TAM3517
Date: Thu, 24 Nov 2011 23:42:00 +0100 [thread overview]
Message-ID: <4ECEC838.60807@denx.de> (raw)
In-Reply-To: <20111124204307.D6A2C1FFB39F@gemini.denx.de>
Am 24/11/2011 21:43, schrieb Wolfgang Denk:
>> + "hostname=" xstr(CONFIG_HOSTNAME) "\0" \
>> + "bootfile=" xstr(CONFIG_HOSTNAME) "/uImage\0" \
>
> Here you rely on xstr() being defined in some higher level header
> file.
This was not thought, I miss to move it, thanks for pointing out
> That's not a good idea.
..it's a very bad idea....
> Please mode the definitions into this
> common header, and drop it in the other file(s).
I do it
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2011-11-24 22:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 9:26 [U-Boot] Adding support to Technexion TAM3517 SOM Stefano Babic
2011-11-23 9:26 ` [U-Boot] [PATCH 1/2] ARM: omap3: added common configuration for Technexion TAM3517 Stefano Babic
2011-11-23 12:44 ` Igor Grinberg
2011-11-23 13:08 ` Stefano Babic
2011-11-23 16:11 ` Wolfgang Denk
2011-11-23 16:29 ` Igor Grinberg
2011-11-23 16:21 ` Wolfgang Denk
2011-11-24 2:47 ` Tom Rini
2011-11-24 9:07 ` Stefano Babic
2011-11-24 12:07 ` Wolfgang Denk
2011-12-01 9:56 ` [U-Boot] [PATCH V3 " Stefano Babic
2011-12-01 9:56 ` [U-Boot] [PATCH V3 2/2] ARM: omap3: add support to Technexion twister board Stefano Babic
2012-01-14 8:47 ` Albert ARIBAUD
2012-01-14 9:48 ` Stefano Babic
2012-01-14 10:06 ` Albert ARIBAUD
2012-01-14 10:15 ` Stefano Babic
2012-01-14 10:22 ` Albert ARIBAUD
2012-01-14 14:25 ` Tom Rini
2012-01-14 15:05 ` Stefano Babic
2011-12-05 23:31 ` [U-Boot] [PATCH V3 1/2] ARM: omap3: added common configuration for Technexion TAM3517 Tom Rini
2011-11-23 9:26 ` [U-Boot] [PATCH 2/2] ARM: omap3: add support to Technexion twister board Stefano Babic
2011-11-23 13:47 ` Igor Grinberg
2011-11-23 14:22 ` Stefano Babic
2011-11-23 14:18 ` Igor Grinberg
2011-11-23 14:41 ` Stefano Babic
2011-11-23 15:20 ` Igor Grinberg
2011-11-23 16:27 ` Wolfgang Denk
[not found] ` <20111124145753.04084d1b@myhost>
2011-11-24 8:05 ` [U-Boot] Adding support to Technexion TAM3517 SOM Stefano Babic
2011-11-24 12:04 ` Wolfgang Denk
2011-11-24 12:30 ` Stefano Babic
2011-11-24 15:19 ` Stefano Babic
2011-11-25 3:25 ` Tapani Utriainen
2011-11-25 7:35 ` Stefano Babic
2011-11-24 15:44 ` [U-Boot] [PATCH V2 1/2] ARM: omap3: added common configuration for Technexion TAM3517 Stefano Babic
2011-11-24 15:44 ` [U-Boot] [PATCH V2 2/2] ARM: omap3: add support to Technexion twister board Stefano Babic
2011-11-24 20:40 ` Wolfgang Denk
2011-11-29 23:18 ` Tom Rini
2011-11-30 8:53 ` Stefano Babic
2011-12-01 11:33 ` Tapani Utriainen
2011-12-01 14:40 ` Wolfgang Denk
2011-11-24 20:43 ` [U-Boot] [PATCH V2 1/2] ARM: omap3: added common configuration for Technexion TAM3517 Wolfgang Denk
2011-11-24 22:42 ` stefano babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECEC838.60807@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.