From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC/PATCH] davinci: disable dcache on boards with EMAC
Date: Sun, 27 Nov 2011 22:37:19 +0400 [thread overview]
Message-ID: <4ED2835F.4010802@emcraft.com> (raw)
In-Reply-To: <20111127180945.E0BBB1FFB3AC@gemini.denx.de>
Dear Wolfgang,
On 27.11.2011 22:09, Wolfgang Denk wrote:
>> To be clear, the problem is that today the driver is broken (not cache
>> safe) and this series of patches fixes that problem. In doing so we
>> expose that arm926ejs doesn't have complete cache support today.
>
> But the cahce support works fine for a lot of things - basicly
> everything except for the broken drivers. Why do you want to make ALL
> user suffer from this, even if they don't intend to use the broken
> driver(s) at all?
Please note that I've already fixed the driver itself but the patch is
still not accepted (because of this problem).
> For example, booting from NAND is probably MUCH faster with caches on.
> Why should we make this slower than necessary?
>
>> But cache support is incomplete is the problem. None of the flushing
>> operations exist.
>
> Then fix _THAT_.
Hm. So I've fixed the broken driver but you aren't going to accept the
patch and say "Please go ahead and fix arm926ejs cache support also".
But it's not even the SoC type I'm working with...
>>> It should be sufficient to switch the cache off ("dc off") before
>>> runnign any network related commands (and you want to make sure to
>>> switch it on again afterwards).
>>
>> We can't because we can't compile the driver, once we make it cache
>> safe. It's not today and at least anecdotally the driver doesn't work
>> today on these platforms unless you turn off dcache.
>
> We cannot _compile_ the driver? That's even worse and needs to be
> fixed.
Alternatively we can just drop the driver cache-related fix, leave the
driver broken and work with the network with "dc off" trick on AM35x also.
Do you think this will be better?
Regards, Ilya.
next prev parent reply other threads:[~2011-11-27 18:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 21:56 [U-Boot] [RFC/PATCH] davinci: disable dcache on boards with EMAC Ilya Yanok
2011-11-11 22:10 ` Andy Fleming
2011-11-11 23:53 ` Tom Rini
2011-11-14 14:07 ` Ben Gardiner
2011-11-15 0:09 ` [U-Boot] [PATCH V2] " Ilya Yanok
2011-11-27 15:09 ` Wolfgang Denk
2011-11-27 15:09 ` [U-Boot] [RFC/PATCH] " Wolfgang Denk
2011-11-27 16:41 ` Tom Rini
2011-11-27 18:09 ` Wolfgang Denk
2011-11-27 18:18 ` Tom Rini
2011-11-27 18:43 ` Wolfgang Denk
2011-11-27 18:51 ` Tom Rini
2011-11-27 19:16 ` Wolfgang Denk
2011-11-27 18:37 ` Ilya Yanok [this message]
2011-11-27 18:49 ` Wolfgang Denk
2011-11-27 19:22 ` Ilya Yanok
2011-11-27 19:36 ` Wolfgang Denk
2011-11-28 12:56 ` Albert ARIBAUD
2011-11-28 16:45 ` Ilya Yanok
2011-11-28 12:06 ` Christian Riesch
2011-11-28 14:53 ` Tom Rini
2011-11-28 15:43 ` Christian Riesch
2011-11-28 15:59 ` Wolfgang Denk
2011-11-29 7:56 ` Christian Riesch
2011-11-28 16:02 ` Ilya Yanok
2011-11-28 16:36 ` Wolfgang Denk
2011-11-29 7:58 ` Christian Riesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED2835F.4010802@emcraft.com \
--to=yanok@emcraft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.