All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilya Yanok <yanok@emcraft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC/PATCH] davinci: disable dcache on boards with EMAC
Date: Mon, 28 Nov 2011 20:02:34 +0400	[thread overview]
Message-ID: <4ED3B09A.7060101@emcraft.com> (raw)
In-Reply-To: <CABkLOboon_r_xwZOriHBhnNRM4+jFYKVKqDVToih6CvCKxs0zA@mail.gmail.com>

Hi Christian,

On 28.11.2011 19:43, Christian Riesch wrote:
>>> What do you mean by "broken"? Is it "never working" or is it "working
>>> sometimes" or "not working under specific conditions"? I have a DA850
>>> based board and I use the Davinci EMAC driver (CONFIG_DRIVER_TI_EMAC).
>>> I don't have these CONFIG_SYS_xCACHE_OFF defines in my board config
>>> file so I guess D-Cache is enabled. But Ethernet works fine, so what
>>> am I missing here? Is D-Cache disabled somewhere else?
>>
>> Today, right now?  I tried a dm365evm back in August on top-of-tree
>> and emac didn't work until I disabled caches.  I don't have day-to-day
>> access to that board however to confirm the current state.
> 
> Yes, right now.

I think it's because of:

commit cba4b1809f043bf85c806e5a4e342f62bd5ded45
Author: Aneesh V <aneesh@ti.com>
Date:   Tue Aug 16 04:33:05 2011 +0000

    arm: do not force d-cache enable on all boards

    c2dd0d45540397704de9b13287417d21049d34c6 added dcache_enable()
    to board_init_r(). This enables d-cache for all ARM boards.
    As a result some of the arm boards that are not cache-ready
    are broken. Revert this change and allow platform code to
    take the decision on d-cache enabling.

    Also add some documentation for cache usage in ARM.

    Signed-off-by: Aneesh V <aneesh@ti.com>

Don't you see "WARNING: Caches not enabled" message during boot?

2Wolfgang: So caches are actually disabled on everything except OMAP...

Regards, Ilya.

  parent reply	other threads:[~2011-11-28 16:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 21:56 [U-Boot] [RFC/PATCH] davinci: disable dcache on boards with EMAC Ilya Yanok
2011-11-11 22:10 ` Andy Fleming
2011-11-11 23:53   ` Tom Rini
2011-11-14 14:07     ` Ben Gardiner
2011-11-15  0:09       ` [U-Boot] [PATCH V2] " Ilya Yanok
2011-11-27 15:09         ` Wolfgang Denk
2011-11-27 15:09 ` [U-Boot] [RFC/PATCH] " Wolfgang Denk
2011-11-27 16:41   ` Tom Rini
2011-11-27 18:09     ` Wolfgang Denk
2011-11-27 18:18       ` Tom Rini
2011-11-27 18:43         ` Wolfgang Denk
2011-11-27 18:51           ` Tom Rini
2011-11-27 19:16             ` Wolfgang Denk
2011-11-27 18:37       ` Ilya Yanok
2011-11-27 18:49         ` Wolfgang Denk
2011-11-27 19:22           ` Ilya Yanok
2011-11-27 19:36             ` Wolfgang Denk
2011-11-28 12:56               ` Albert ARIBAUD
2011-11-28 16:45                 ` Ilya Yanok
2011-11-28 12:06     ` Christian Riesch
2011-11-28 14:53       ` Tom Rini
2011-11-28 15:43         ` Christian Riesch
2011-11-28 15:59           ` Wolfgang Denk
2011-11-29  7:56             ` Christian Riesch
2011-11-28 16:02           ` Ilya Yanok [this message]
2011-11-28 16:36             ` Wolfgang Denk
2011-11-29  7:58             ` Christian Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED3B09A.7060101@emcraft.com \
    --to=yanok@emcraft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.