All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] fix out of tree build
Date: Mon, 28 Nov 2011 19:34:16 +0100	[thread overview]
Message-ID: <4ED3D428.7030704@weilnetz.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1111221726190.31179@kaball-desktop>

Am 22.11.2011 18:27, schrieb Stefano Stabellini:
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> diff --git a/Makefile b/Makefile
> index 168093c..885065f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -167,7 +167,7 @@ check-qjson: check-qjson.o $(qobject-obj-y) 
> $(tools-obj-y)
> test-coroutine: test-coroutine.o qemu-timer-common.o async.o 
> $(coroutine-obj-y) $(tools-obj-y)
>
> $(qapi-obj-y): $(GENERATED_HEADERS)
> -qapi-dir := qapi-generated
> +qapi-dir := $(SRC_PATH)/qapi-generated
> test-visitor.o test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I 
> $(qapi-dir)
> qemu-ga$(EXESUF): LIBS = $(LIBS_QGA)

This patch was committed to latest QEMU and breaks in-tree and 
out-of-tree builds.
Without it, both kinds of builds work in my standard Debian configuration.

Regards,
Stefan Weil


gcc output (extract):

CC /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.o
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: 
In function ‘qapi_free_GuestAgentInfoList’:
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:39: 
warning: implicit declaration of function ‘visit_type_GuestAgentInfoList’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:39: 
warning: nested extern declaration of ‘visit_type_GuestAgentInfoList’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: 
In function ‘qapi_free_GuestAgentInfo’:
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:54: 
warning: implicit declaration of function ‘visit_type_GuestAgentInfo’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:54: 
warning: nested extern declaration of ‘visit_type_GuestAgentInfo’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: 
In function ‘qapi_free_GuestFileReadList’:
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:69: 
warning: implicit declaration of function ‘visit_type_GuestFileReadList’



WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fix out of tree build
Date: Mon, 28 Nov 2011 19:34:16 +0100	[thread overview]
Message-ID: <4ED3D428.7030704@weilnetz.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1111221726190.31179@kaball-desktop>

Am 22.11.2011 18:27, schrieb Stefano Stabellini:
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
> diff --git a/Makefile b/Makefile
> index 168093c..885065f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -167,7 +167,7 @@ check-qjson: check-qjson.o $(qobject-obj-y) 
> $(tools-obj-y)
> test-coroutine: test-coroutine.o qemu-timer-common.o async.o 
> $(coroutine-obj-y) $(tools-obj-y)
>
> $(qapi-obj-y): $(GENERATED_HEADERS)
> -qapi-dir := qapi-generated
> +qapi-dir := $(SRC_PATH)/qapi-generated
> test-visitor.o test-qmp-commands.o qemu-ga$(EXESUF): QEMU_CFLAGS += -I 
> $(qapi-dir)
> qemu-ga$(EXESUF): LIBS = $(LIBS_QGA)

This patch was committed to latest QEMU and breaks in-tree and 
out-of-tree builds.
Without it, both kinds of builds work in my standard Debian configuration.

Regards,
Stefan Weil


gcc output (extract):

CC /home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.o
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: 
In function ‘qapi_free_GuestAgentInfoList’:
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:39: 
warning: implicit declaration of function ‘visit_type_GuestAgentInfoList’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:39: 
warning: nested extern declaration of ‘visit_type_GuestAgentInfoList’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: 
In function ‘qapi_free_GuestAgentInfo’:
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:54: 
warning: implicit declaration of function ‘visit_type_GuestAgentInfo’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:54: 
warning: nested extern declaration of ‘visit_type_GuestAgentInfo’
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c: 
In function ‘qapi_free_GuestFileReadList’:
/home/stefan/src/qemu/qemu.org/patches/qapi-generated/qga-qapi-types.c:69: 
warning: implicit declaration of function ‘visit_type_GuestFileReadList’

  parent reply	other threads:[~2011-11-28 18:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 17:27 [Qemu-trivial] [PATCH] fix out of tree build Stefano Stabellini
2011-11-22 17:27 ` [Qemu-devel] " Stefano Stabellini
2011-11-23  9:48 ` [Qemu-trivial] " Stefan Hajnoczi
2011-11-23  9:48   ` [Qemu-devel] " Stefan Hajnoczi
2011-11-28 18:34 ` Stefan Weil [this message]
2011-11-28 18:34   ` [Qemu-devel] " Stefan Weil
2011-11-28 18:45   ` [Qemu-trivial] " Anthony Liguori
2011-11-28 18:45     ` Anthony Liguori
2011-11-28 20:40   ` [Qemu-trivial] " Stefan Weil
2011-11-28 20:40     ` Stefan Weil
2011-11-29 16:23     ` [Qemu-trivial] " Stefano Stabellini
2011-11-29 16:23       ` Stefano Stabellini
2011-11-29 22:47     ` [Qemu-trivial] [PATCH 1/2] qapi: fix guardname generation Michael Roth
2011-11-29 22:47       ` [Qemu-devel] " Michael Roth
2011-11-29 22:47       ` [Qemu-trivial] [PATCH 2/2] Makefile: use full path for qapi-generated directory Michael Roth
2011-11-29 22:47         ` [Qemu-devel] " Michael Roth
2011-11-30  9:10         ` [Qemu-trivial] " Stefan Hajnoczi
2011-11-30  9:10           ` [Qemu-devel] " Stefan Hajnoczi
2011-11-30 13:03           ` Stefano Stabellini
2011-11-30 13:03             ` [Qemu-devel] " Stefano Stabellini
2011-11-30 19:59             ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2011-11-30 19:59               ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
2011-12-01 15:19               ` [Qemu-trivial] [Qemu-devel] " Stefano Stabellini
2011-12-01 15:19                 ` [Qemu-devel] [Qemu-trivial] " Stefano Stabellini
2011-12-01 16:05                 ` [Qemu-trivial] [Qemu-devel] " Michael Roth
2011-12-01 16:05                   ` [Qemu-devel] [Qemu-trivial] " Michael Roth
2011-12-01 18:11                 ` [Qemu-trivial] [Qemu-devel] " Stefan Weil
2011-12-01 18:11                   ` [Qemu-devel] [Qemu-trivial] " Stefan Weil
2011-12-01 18:28                   ` [Qemu-trivial] [Qemu-devel] " Anthony Liguori
2011-12-01 18:28                     ` [Qemu-devel] [Qemu-trivial] " Anthony Liguori
2011-12-01 18:42                     ` [Qemu-trivial] [Qemu-devel] " Stefano Stabellini
2011-12-01 18:42                       ` [Qemu-devel] [Qemu-trivial] " Stefano Stabellini
2011-12-01 19:12                       ` [Qemu-trivial] [Qemu-devel] " Michael Roth
2011-12-01 19:12                         ` [Qemu-devel] [Qemu-trivial] " Michael Roth
2011-12-01 18:38                   ` [Qemu-trivial] [Qemu-devel] " Stefano Stabellini
2011-12-01 18:38                     ` [Qemu-devel] [Qemu-trivial] " Stefano Stabellini
2011-11-30  9:08       ` [Qemu-trivial] [PATCH 1/2] qapi: fix guardname generation Stefan Hajnoczi
2011-11-30  9:08         ` [Qemu-devel] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED3D428.7030704@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.