From: Jaehoon Chung <jh80.chung@samsung.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>, Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] mmc: sdhci-s3c: Remove old and misprototyped suspend operations
Date: Wed, 30 Nov 2011 00:05:40 +0900 [thread overview]
Message-ID: <4ED4F4C4.2020805@samsung.com> (raw)
In-Reply-To: <1321898451-5347-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 11/22/2011 03:00 AM, Mark Brown wrote:
> Now that the driver is using dev_pm_ops the suspend operations in the
> platform_driver structure won't get called so don't need to be there,
> and certainly shouldn't be the same function as dev_pm_ops since the
> signatures are different.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 4cb272c..9a20d1f 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -647,8 +647,6 @@ static const struct dev_pm_ops sdhci_s3c_pmops = {
> static struct platform_driver sdhci_s3c_driver = {
> .probe = sdhci_s3c_probe,
> .remove = __devexit_p(sdhci_s3c_remove),
> - .suspend = sdhci_s3c_suspend,
> - .resume = sdhci_s3c_resume,
> .driver = {
> .owner = THIS_MODULE,
> .name = "s3c-sdhci",
next prev parent reply other threads:[~2011-11-29 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 18:00 [PATCH] mmc: sdhci-s3c: Remove old and misprototyped suspend operations Mark Brown
2011-11-29 15:05 ` Jaehoon Chung [this message]
2011-12-01 18:08 ` Chris Ball
2011-12-19 10:15 ` Tushar Behera
2011-12-25 2:29 ` Chris Ball
2011-12-26 1:54 ` Jaehoon Chung
2011-12-26 5:05 ` Tushar Behera
2011-12-26 5:23 ` Jaehoon Chung
2011-12-26 6:00 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED4F4C4.2020805@samsung.com \
--to=jh80.chung@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.