From: Chris Ball <cjb@laptop.org>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-s3c: Remove old and misprototyped suspend operations
Date: Sat, 24 Dec 2011 21:29:39 -0500 [thread overview]
Message-ID: <m239c9z8mk.fsf@bob.laptop.org> (raw)
In-Reply-To: <loom.20111219T110819-762@post.gmane.org> (Tushar Behera's message of "Mon, 19 Dec 2011 10:15:27 +0000 (UTC)")
Hi,
On Mon, Dec 19 2011, Tushar Behera wrote:
>> >> Now that the driver is using dev_pm_ops the suspend operations in the
>> >> platform_driver structure won't get called so don't need to be there,
>> >> and certainly shouldn't be the same function as dev_pm_ops since the
>> >> signatures are different.
>> >>
>> >> Signed-off-by: Mark Brown <broonie <at> opensource.wolfsonmicro.com>
>
> On Origen board (based on EXYNOS4210), the primary filesystem is on a
> SD/MMC card. When tested with v3.2-rc6 kernel, the system doesn't resume
> properly.
>
> After resume, it keeps printing following message and the filesystem never
> comes up.
>
> mmc0: Timeout waiting for hardware interrupt.
>
> If this patch is reverted, the system is able to mount the filesystem
> successfully.
>
> Am I missing something?
Mark/Jaehoon? This looks very bad.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-12-25 2:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 18:00 [PATCH] mmc: sdhci-s3c: Remove old and misprototyped suspend operations Mark Brown
2011-11-29 15:05 ` Jaehoon Chung
2011-12-01 18:08 ` Chris Ball
2011-12-19 10:15 ` Tushar Behera
2011-12-25 2:29 ` Chris Ball [this message]
2011-12-26 1:54 ` Jaehoon Chung
2011-12-26 5:05 ` Tushar Behera
2011-12-26 5:23 ` Jaehoon Chung
2011-12-26 6:00 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m239c9z8mk.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.