Re: [PATCH 3/3] MIPS: changes in VM core for adding THP

[David Daney <ddaney.cavm@gmail.com>]

On 11/29/2011 09:50 AM, Rik van Riel wrote:
> On 11/26/2011 12:31 PM, Andrea Arcangeli wrote:
>> On Sat, Nov 26, 2011 at 10:43:15PM +0800, Hillf Danton wrote:
>>> In VM core, window is opened for MIPS to use THP.
>>>
>>> And two simple helper functions are added to easy MIPS a bit.
>>>
>>> Signed-off-by: Hillf Danton<dhillf@gmail.com>
>>> ---
>>>
>>> --- a/mm/Kconfig Thu Nov 24 21:12:00 2011
>>> +++ b/mm/Kconfig Sat Nov 26 22:12:56 2011
>>> @@ -307,7 +307,7 @@ config NOMMU_INITIAL_TRIM_EXCESS
>>>
>>> config TRANSPARENT_HUGEPAGE
>>> bool "Transparent Hugepage Support"
>>> - depends on X86&& MMU
>>> + depends on MMU
>>> select COMPACTION
>>> help
>>> Transparent Hugepages allows the kernel to use huge pages and
>>
>> Then the build will break for all archs if they enable it, better to
>> limit the option to those archs that supports it.
>
> Would it be an idea to define ARCH_HAVE_HUGEPAGE in the
> arch specific Kconfig file and test against that in
> mm/Kconfig ?
>

I think so, but it would probably be spelled ARCH_HAVE_TRANSPARENT_HUGEPAGE

The practice of putting 'depends on X86' in archecture independent 
Kconfigs should really be discouraged.  It has a real feel of hackyness 
to it.

David Daney