From: Boaz Harrosh <bharrosh@panasas.com>
To: Randy Dunlap <rdunlap@xenotime.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Michal Marek <mmarek@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>,
NFS list <linux-nfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Benny Halevy <bhalevy@tonian.com>,
linux-next@vger.kernel.org, open-osd <osd-dev@open-osd.org>
Subject: [PATCH v3] ore: FIX breakage when MISC_FILESYSTEMS is not set
Date: Tue, 29 Nov 2011 15:35:53 -0800 [thread overview]
Message-ID: <4ED56C59.208@panasas.com> (raw)
In-Reply-To: <4ED4238F.4090407@panasas.com>
As Reported by Randy Dunlap
When MISC_FILESYSTEMS is not enabled:
fs/built-in.o: In function `objio_alloc_io_state':
objio_osd.c:(.text+0xcb525): undefined reference to `ore_get_rw_state'
fs/built-in.o: In function `_write_done':
objio_osd.c:(.text+0xcb58d): undefined reference to `ore_check_io'
fs/built-in.o: In function `_read_done':
...
When MISC_FILESYSTEMS, which is more of a GUI thing then anything else,
is not selected. exofs/Kconfig is never examined during Kconfig,
and it can not do it's magic stuff to automatically select everything
needed.
We must split exofs/Kconfig in two. The ore one is always included.
And the exofs one is left in it's old place in the menu.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/Kconfig | 2 ++
fs/exofs/Kconfig | 11 -----------
fs/exofs/ore.Kconfig | 12 ++++++++++++
3 files changed, 14 insertions(+), 11 deletions(-)
create mode 100644 fs/exofs/ore.Kconfig
diff --git a/fs/Kconfig b/fs/Kconfig
index 5f4c45d..fd7bfef 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -218,6 +218,8 @@ source "fs/exofs/Kconfig"
endif # MISC_FILESYSTEMS
+source "fs/exofs/ore.Kconfig"
+
menuconfig NETWORK_FILESYSTEMS
bool "Network File Systems"
default y
diff --git a/fs/exofs/Kconfig b/fs/exofs/Kconfig
index da42f32..86194b2 100644
--- a/fs/exofs/Kconfig
+++ b/fs/exofs/Kconfig
@@ -1,14 +1,3 @@
-# Note ORE needs to "select ASYNC_XOR". So Not to force multiple selects
-# for every ORE user we do it like this. Any user should add itself here
-# at the "depends on EXOFS_FS || ..." with an ||. The dependencies are
-# selected here, and we default to "ON". So in effect it is like been
-# selected by any of the users.
-config ORE
- tristate
- depends on EXOFS_FS || PNFS_OBJLAYOUT
- select ASYNC_XOR
- default SCSI_OSD_ULD
-
config EXOFS_FS
tristate "exofs: OSD based file system support"
depends on SCSI_OSD_ULD
diff --git a/fs/exofs/ore.Kconfig b/fs/exofs/ore.Kconfig
new file mode 100644
index 0000000..1ca7fb7
--- /dev/null
+++ b/fs/exofs/ore.Kconfig
@@ -0,0 +1,12 @@
+# ORE - Objects Raid Engine (libore.ko)
+#
+# Note ORE needs to "select ASYNC_XOR". So Not to force multiple selects
+# for every ORE user we do it like this. Any user should add itself here
+# at the "depends on EXOFS_FS || ..." with an ||. The dependencies are
+# selected here, and we default to "ON". So in effect it is like been
+# selected by any of the users.
+config ORE
+ tristate
+ depends on EXOFS_FS || PNFS_OBJLAYOUT
+ select ASYNC_XOR
+ default SCSI_OSD_ULD
--
1.7.6.4
WARNING: multiple messages have this Message-ID (diff)
From: Boaz Harrosh <bharrosh@panasas.com>
To: Randy Dunlap <rdunlap@xenotime.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Michal Marek <mmarek@suse.cz>,
Stephen Rothwell <sfr@canb.auug.org.au>,
NFS list <linux-nfs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Benny Halevy <bhalevy@tonian.com>, <linux-next@vger.kernel.org>,
open-osd <osd-dev@open-osd.org>
Subject: [PATCH v3] ore: FIX breakage when MISC_FILESYSTEMS is not set
Date: Tue, 29 Nov 2011 15:35:53 -0800 [thread overview]
Message-ID: <4ED56C59.208@panasas.com> (raw)
In-Reply-To: <4ED4238F.4090407@panasas.com>
As Reported by Randy Dunlap
When MISC_FILESYSTEMS is not enabled:
fs/built-in.o: In function `objio_alloc_io_state':
objio_osd.c:(.text+0xcb525): undefined reference to `ore_get_rw_state'
fs/built-in.o: In function `_write_done':
objio_osd.c:(.text+0xcb58d): undefined reference to `ore_check_io'
fs/built-in.o: In function `_read_done':
...
When MISC_FILESYSTEMS, which is more of a GUI thing then anything else,
is not selected. exofs/Kconfig is never examined during Kconfig,
and it can not do it's magic stuff to automatically select everything
needed.
We must split exofs/Kconfig in two. The ore one is always included.
And the exofs one is left in it's old place in the menu.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/Kconfig | 2 ++
fs/exofs/Kconfig | 11 -----------
fs/exofs/ore.Kconfig | 12 ++++++++++++
3 files changed, 14 insertions(+), 11 deletions(-)
create mode 100644 fs/exofs/ore.Kconfig
diff --git a/fs/Kconfig b/fs/Kconfig
index 5f4c45d..fd7bfef 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -218,6 +218,8 @@ source "fs/exofs/Kconfig"
endif # MISC_FILESYSTEMS
+source "fs/exofs/ore.Kconfig"
+
menuconfig NETWORK_FILESYSTEMS
bool "Network File Systems"
default y
diff --git a/fs/exofs/Kconfig b/fs/exofs/Kconfig
index da42f32..86194b2 100644
--- a/fs/exofs/Kconfig
+++ b/fs/exofs/Kconfig
@@ -1,14 +1,3 @@
-# Note ORE needs to "select ASYNC_XOR". So Not to force multiple selects
-# for every ORE user we do it like this. Any user should add itself here
-# at the "depends on EXOFS_FS || ..." with an ||. The dependencies are
-# selected here, and we default to "ON". So in effect it is like been
-# selected by any of the users.
-config ORE
- tristate
- depends on EXOFS_FS || PNFS_OBJLAYOUT
- select ASYNC_XOR
- default SCSI_OSD_ULD
-
config EXOFS_FS
tristate "exofs: OSD based file system support"
depends on SCSI_OSD_ULD
diff --git a/fs/exofs/ore.Kconfig b/fs/exofs/ore.Kconfig
new file mode 100644
index 0000000..1ca7fb7
--- /dev/null
+++ b/fs/exofs/ore.Kconfig
@@ -0,0 +1,12 @@
+# ORE - Objects Raid Engine (libore.ko)
+#
+# Note ORE needs to "select ASYNC_XOR". So Not to force multiple selects
+# for every ORE user we do it like this. Any user should add itself here
+# at the "depends on EXOFS_FS || ..." with an ||. The dependencies are
+# selected here, and we default to "ON". So in effect it is like been
+# selected by any of the users.
+config ORE
+ tristate
+ depends on EXOFS_FS || PNFS_OBJLAYOUT
+ select ASYNC_XOR
+ default SCSI_OSD_ULD
--
1.7.6.4
next prev parent reply other threads:[~2011-11-29 23:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 6:43 linux-next: Tree for Nov 24 Stephen Rothwell
2011-11-24 18:50 ` linux-next: Tree for Nov 24 (fs/pnfs vs. exofs) Randy Dunlap
2011-11-29 0:09 ` Boaz Harrosh
2011-11-29 0:09 ` Boaz Harrosh
[not found] ` <4ED422CC.60706-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2011-11-29 0:13 ` ore: FIX breakage when MISC_FILESYSTEMS is not set Boaz Harrosh
2011-11-29 0:13 ` Boaz Harrosh
2011-11-29 12:21 ` Benny Halevy
2011-11-29 17:33 ` Trond Myklebust
[not found] ` <1322588023.4174.28.camel-SyLVLa/KEI9HwK5hSS5vWB2eb7JE58TQ@public.gmane.org>
2011-11-29 22:22 ` Boaz Harrosh
2011-11-29 22:22 ` Boaz Harrosh
[not found] ` <4ED55B3B.9050207-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org>
2011-11-29 22:36 ` Trond Myklebust
2011-11-29 22:36 ` Trond Myklebust
2011-11-29 22:38 ` Trond Myklebust
2011-11-29 23:33 ` Boaz Harrosh
2011-11-29 23:33 ` Boaz Harrosh
2011-11-29 23:39 ` Randy Dunlap
2011-11-29 23:30 ` Boaz Harrosh
2011-11-29 23:30 ` Boaz Harrosh
2011-11-29 23:35 ` Boaz Harrosh [this message]
2011-11-29 23:35 ` [PATCH v3] " Boaz Harrosh
2011-11-30 1:00 ` [osd-dev] " Boaz Harrosh
2011-11-30 1:00 ` Boaz Harrosh
2011-11-30 18:00 ` Randy Dunlap
2011-11-30 8:31 ` Michal Marek
2011-11-30 16:32 ` Boaz Harrosh
2011-11-30 16:32 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED56C59.208@panasas.com \
--to=bharrosh@panasas.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bhalevy@tonian.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=osd-dev@open-osd.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.