* [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
@ 2011-11-29 14:22 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 10+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-11-29 14:22 UTC (permalink / raw)
To: ath9k-devel
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
before concluding that the recieved beacon is for us, let us make sure
that the BSSID is non-zero.
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/recv.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index 4c8e296..620230d 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -1824,6 +1824,7 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
hdr = (struct ieee80211_hdr *) (hdr_skb->data + rx_status_len);
rxs = IEEE80211_SKB_RXCB(hdr_skb);
if (ieee80211_is_beacon(hdr->frame_control) &&
+ !is_zero_ether_addr(common->curbssid) &&
!compare_ether_addr(hdr->addr3, common->curbssid))
rs.is_mybeacon = true;
else
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC] ath9k: validate for non-zero BSSID
@ 2011-11-29 14:22 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 10+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-11-29 14:22 UTC (permalink / raw)
To: John W. Linville
Cc: Jouni Malinen, linux-wireless, Rodriguez Luis,
Balasubramanian senthilkumar, Vasanthakumar Thiagarajan,
Rajkumar Manoharan, Vivek Natarajan, ath9k-devel,
Mohammed Shafi Shajakhan
From: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
before concluding that the recieved beacon is for us, let us make sure
that the BSSID is non-zero.
Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com>
---
drivers/net/wireless/ath/ath9k/recv.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
index 4c8e296..620230d 100644
--- a/drivers/net/wireless/ath/ath9k/recv.c
+++ b/drivers/net/wireless/ath/ath9k/recv.c
@@ -1824,6 +1824,7 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
hdr = (struct ieee80211_hdr *) (hdr_skb->data + rx_status_len);
rxs = IEEE80211_SKB_RXCB(hdr_skb);
if (ieee80211_is_beacon(hdr->frame_control) &&
+ !is_zero_ether_addr(common->curbssid) &&
!compare_ether_addr(hdr->addr3, common->curbssid))
rs.is_mybeacon = true;
else
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
2011-11-29 14:22 ` Mohammed Shafi Shajakhan
@ 2011-11-30 2:36 ` Peter Stuge
-1 siblings, 0 replies; 10+ messages in thread
From: Peter Stuge @ 2011-11-30 2:36 UTC (permalink / raw)
To: ath9k-devel
Mohammed Shafi Shajakhan wrote:
> before concluding that the recieved beacon is for us, let us make sure
> that the BSSID is non-zero.
Under what circumstances would the BSSID be zero?
//Peter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
@ 2011-11-30 2:36 ` Peter Stuge
0 siblings, 0 replies; 10+ messages in thread
From: Peter Stuge @ 2011-11-30 2:36 UTC (permalink / raw)
To: Mohammed Shafi Shajakhan
Cc: John W. Linville, Vasanthakumar Thiagarajan, Jouni Malinen,
ath9k-devel, linux-wireless, Rodriguez Luis, Vivek Natarajan,
Balasubramanian senthilkumar, Rajkumar Manoharan
Mohammed Shafi Shajakhan wrote:
> before concluding that the recieved beacon is for us, let us make sure
> that the BSSID is non-zero.
Under what circumstances would the BSSID be zero?
//Peter
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
2011-11-30 2:36 ` Peter Stuge
@ 2011-11-30 5:21 ` Mohammed Shafi Shajakhan
-1 siblings, 0 replies; 10+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-11-30 5:21 UTC (permalink / raw)
To: ath9k-devel
Hi Peter,
On Wednesday 30 November 2011 08:06 AM, Peter Stuge wrote:
> Mohammed Shafi Shajakhan wrote:
>> before concluding that the recieved beacon is for us, let us make sure
>> that the BSSID is non-zero.
>
> Under what circumstances would the BSSID be zero?
>
>
> //Peter
unassociated state for station.
but I observed this when i tested ad-hoc mode. I just started an ad-hoc
mode creator and left it for some time with no one joining. i observed
there are few frames in rx_tasklet of ath9k driver which seem to be
beacons and their BSSID is '0', as our curbssid is also '0' they seem to
be wrongly identified as 'my_beacons'. let me also verify it in STA mode
and find the effect of this before sending it as a PATCH.
let me also check if it has any effect in ath9k_process_rssi and ath_rx_ps.
--
thanks,
shafi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
@ 2011-11-30 5:21 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 10+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-11-30 5:21 UTC (permalink / raw)
To: John W. Linville, Vasanthakumar Thiagarajan, Jouni Malinen,
ath9k-devel, linux-wireless, Rodriguez Luis, Vivek Natarajan,
Balasubramanian senthilkumar, Rajkumar Manoharan
Hi Peter,
On Wednesday 30 November 2011 08:06 AM, Peter Stuge wrote:
> Mohammed Shafi Shajakhan wrote:
>> before concluding that the recieved beacon is for us, let us make sure
>> that the BSSID is non-zero.
>
> Under what circumstances would the BSSID be zero?
>
>
> //Peter
unassociated state for station.
but I observed this when i tested ad-hoc mode. I just started an ad-hoc
mode creator and left it for some time with no one joining. i observed
there are few frames in rx_tasklet of ath9k driver which seem to be
beacons and their BSSID is '0', as our curbssid is also '0' they seem to
be wrongly identified as 'my_beacons'. let me also verify it in STA mode
and find the effect of this before sending it as a PATCH.
let me also check if it has any effect in ath9k_process_rssi and ath_rx_ps.
--
thanks,
shafi
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
2011-11-30 5:21 ` Mohammed Shafi Shajakhan
@ 2011-11-30 6:47 ` Kalle Valo
-1 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2011-11-30 6:47 UTC (permalink / raw)
To: ath9k-devel
Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com> writes:
> unassociated state for station.
>
> but I observed this when i tested ad-hoc mode. I just started an
> ad-hoc mode creator and left it for some time with no one joining. i
> observed there are few frames in rx_tasklet of ath9k driver which seem
> to be beacons and their BSSID is '0', as our curbssid is also '0' they
> seem to be wrongly identified as 'my_beacons'.
This is a perfect addition to the commit log. Remember that the commit
log should especially answer the question "why?".
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
@ 2011-11-30 6:47 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2011-11-30 6:47 UTC (permalink / raw)
To: Mohammed Shafi Shajakhan
Cc: John W. Linville, Vasanthakumar Thiagarajan, Jouni Malinen,
ath9k-devel, linux-wireless, Rodriguez Luis, Vivek Natarajan,
Balasubramanian senthilkumar, Rajkumar Manoharan
Mohammed Shafi Shajakhan <mohammed@qca.qualcomm.com> writes:
> unassociated state for station.
>
> but I observed this when i tested ad-hoc mode. I just started an
> ad-hoc mode creator and left it for some time with no one joining. i
> observed there are few frames in rx_tasklet of ath9k driver which seem
> to be beacons and their BSSID is '0', as our curbssid is also '0' they
> seem to be wrongly identified as 'my_beacons'.
This is a perfect addition to the commit log. Remember that the commit
log should especially answer the question "why?".
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
2011-11-30 6:47 ` Kalle Valo
@ 2011-11-30 7:11 ` Mohammed Shafi Shajakhan
-1 siblings, 0 replies; 10+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-11-30 7:11 UTC (permalink / raw)
To: ath9k-devel
On Wednesday 30 November 2011 12:17 PM, Kalle Valo wrote:
> Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com> writes:
>
>> unassociated state for station.
>>
>> but I observed this when i tested ad-hoc mode. I just started an
>> ad-hoc mode creator and left it for some time with no one joining. i
>> observed there are few frames in rx_tasklet of ath9k driver which seem
>> to be beacons and their BSSID is '0', as our curbssid is also '0' they
>> seem to be wrongly identified as 'my_beacons'.
>
> This is a perfect addition to the commit log. Remember that the commit
> log should especially answer the question "why?".
>
Kalle, thanks. I will properly test this in STA and IBSS mode, and add
this commit log.
--
thanks,
shafi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID
@ 2011-11-30 7:11 ` Mohammed Shafi Shajakhan
0 siblings, 0 replies; 10+ messages in thread
From: Mohammed Shafi Shajakhan @ 2011-11-30 7:11 UTC (permalink / raw)
To: Kalle Valo
Cc: John W. Linville, Vasanthakumar Thiagarajan, Jouni Malinen,
ath9k-devel, linux-wireless, Rodriguez Luis, Vivek Natarajan,
Balasubramanian senthilkumar, Rajkumar Manoharan
On Wednesday 30 November 2011 12:17 PM, Kalle Valo wrote:
> Mohammed Shafi Shajakhan<mohammed@qca.qualcomm.com> writes:
>
>> unassociated state for station.
>>
>> but I observed this when i tested ad-hoc mode. I just started an
>> ad-hoc mode creator and left it for some time with no one joining. i
>> observed there are few frames in rx_tasklet of ath9k driver which seem
>> to be beacons and their BSSID is '0', as our curbssid is also '0' they
>> seem to be wrongly identified as 'my_beacons'.
>
> This is a perfect addition to the commit log. Remember that the commit
> log should especially answer the question "why?".
>
Kalle, thanks. I will properly test this in STA and IBSS mode, and add
this commit log.
--
thanks,
shafi
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-11-30 7:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-29 14:22 [ath9k-devel] [RFC] ath9k: validate for non-zero BSSID Mohammed Shafi Shajakhan
2011-11-29 14:22 ` Mohammed Shafi Shajakhan
2011-11-30 2:36 ` [ath9k-devel] " Peter Stuge
2011-11-30 2:36 ` Peter Stuge
2011-11-30 5:21 ` Mohammed Shafi Shajakhan
2011-11-30 5:21 ` Mohammed Shafi Shajakhan
2011-11-30 6:47 ` Kalle Valo
2011-11-30 6:47 ` Kalle Valo
2011-11-30 7:11 ` Mohammed Shafi Shajakhan
2011-11-30 7:11 ` Mohammed Shafi Shajakhan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.