Re: [PATCH net-next] tcp: inherit listener congestion control for passive cnx

[Rick Jones <rick.jones2@hp.com>]

On 11/30/2011 03:02 AM, Eric Dumazet wrote:
> Le mercredi 30 novembre 2011 à 06:40 +0100, Eric Dumazet a écrit :
>> Le mercredi 30 novembre 2011 à 06:21 +0100, Eric Dumazet a écrit :
>>
>>> So my suggestion would be to use this two lines patch instead :
>>>
>>> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
>>> index 945efff..6b066e2 100644
>>> --- a/net/ipv4/tcp_minisocks.c
>>> +++ b/net/ipv4/tcp_minisocks.c
>>> @@ -495,8 +495,6 @@ struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req,
>>>   		newtp->frto_counter = 0;
>>>   		newtp->frto_highmark = 0;
>>>
>>> -		newicsk->icsk_ca_ops =&tcp_init_congestion_ops;
>>> -
>>>   		tcp_set_ca_state(newsk, TCP_CA_Open);
>>>   		tcp_init_xmit_timers(newsk);
>>>   		skb_queue_head_init(&newtp->out_of_order_queue);
>>>
>>
>> Please test this change and if its OK, resubmit your patch, with
>> appropriate Documentation change, as pointed out by Yuchung Cheng
>
> Hmm, after taking more time on this, we have to take care of module
> refcounting and proper cleanup. I hope you dont mind I submit my final
> version of this patch.

I do not mind at all.

rick