From: Rick Jones <rick.jones2@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Yuchung Cheng <ycheng@google.com>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH net-next] tcp: inherit listener congestion control for passive cnx
Date: Wed, 30 Nov 2011 13:28:57 -0800 [thread overview]
Message-ID: <4ED6A019.2040708@hp.com> (raw)
In-Reply-To: <1322650961.2403.13.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
>
> Rick Jones reported that TCP_CONGESTION sockopt performed on a listener
> was ignored for its children sockets : right after accept() the
> congestion control for new socket is the system default one.
>
> This seems an oversight of the initial design (quoted from Stephen)
>
> Based on prior investigation and patch from Rick.
>
> Reported-by: Rick Jones<rick.jones2@hp.com>
> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com>
> CC: Stephen Hemminger<shemminger@vyatta.com>
> CC: Yuchung Cheng<ycheng@google.com>
Tested-by: Rick Jones <rick.jones2@hp.com>
Works as expected/desired with my test program, and doesn't appear to
affect performance measurably (loopback netperf TCP_CC test on a 1 VCPU
guest).
rick jones
next prev parent reply other threads:[~2011-11-30 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 0:31 [RFC net-next] Include selection of congestion control algorithm in that which is inherited across an accept() call Rick Jones
2011-11-30 5:21 ` Eric Dumazet
2011-11-30 5:40 ` Eric Dumazet
2011-11-30 11:02 ` [PATCH net-next] tcp: inherit listener congestion control for passive cnx Eric Dumazet
2011-11-30 17:33 ` Rick Jones
2011-11-30 21:28 ` Rick Jones [this message]
2011-11-30 21:56 ` David Miller
2011-11-30 17:21 ` [RFC net-next] Include selection of congestion control algorithm in that which is inherited across an accept() call Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED6A019.2040708@hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.