From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [RFC] KEXEC: allocate crash note buffers at boot time v3
Date: Thu, 1 Dec 2011 14:00:38 +0000 [thread overview]
Message-ID: <4ED78886.6070101@citrix.com> (raw)
In-Reply-To: <CAFCBF30.262CB%keir.xen@gmail.com>
On 01/12/11 05:20, Keir Fraser wrote:
> On 01/12/2011 12:56, "Jan Beulich" <JBeulich@suse.com> wrote:
>
>>> + register_keyhandler('C', &crashdump_trigger_keyhandler);
>>> +
>>> + /* If no crash area, no need to allocate space for notes. */
>>> + if ( 0 == kexec_crash_area.size )
>>> + return 0;
>> Wouldn't it make sense to switch the order of these?
> I also really hate this constant-first ordering.
>
> -- Keir
>
It was a useful habit I got into when learning C/C++ and has stayed with
me. I will endeavor to not do it.
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
next prev parent reply other threads:[~2011-12-01 14:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 18:56 [RFC] KEXEC: allocate crash note buffers at boot time Andrew Cooper
2011-11-29 11:19 ` Keir Fraser
2011-11-30 13:14 ` Andrew Cooper
2011-11-30 17:24 ` [RFC] KEXEC: allocate crash note buffers at boot time v2 Andrew Cooper
2011-12-01 9:08 ` Jan Beulich
2011-12-01 9:49 ` Andrew Cooper
2011-12-01 10:01 ` Jan Beulich
2011-12-01 12:29 ` [RFC] KEXEC: allocate crash note buffers at boot time v3 Andrew Cooper
2011-12-01 12:56 ` Jan Beulich
2011-12-01 5:20 ` Keir Fraser
2011-12-01 14:00 ` Andrew Cooper [this message]
2011-12-01 13:59 ` Andrew Cooper
2011-12-01 15:14 ` Jan Beulich
2011-12-01 15:02 ` Andrew Cooper
2011-12-01 15:15 ` Jan Beulich
2011-12-01 17:14 ` [RFC] KEXEC: allocate crash note buffers at boot time v4 Andrew Cooper
2011-12-02 8:02 ` Jan Beulich
2011-12-02 12:33 ` Andrew Cooper
2011-12-02 15:19 ` KEXEC: allocate crash note buffers at boot time v5 Andrew Cooper
2011-12-02 16:04 ` Jan Beulich
2011-12-02 16:10 ` KEXEC: allocate crash note buffers at boot time v Andrew Cooper
2011-11-30 9:20 ` [RFC] KEXEC: allocate crash note buffers at boot time Jan Beulich
2011-11-30 14:01 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED78886.6070101@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.