From: Jan Kiszka <jan.kiszka@siemens.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "ryanh@linux.vnet.ibm.com" <ryanh@linux.vnet.ibm.com>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eric B Munson <emunson@mgebm.net>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH] Guest stop notification
Date: Thu, 01 Dec 2011 18:35:24 +0100 [thread overview]
Message-ID: <4ED7BADC.4070809@siemens.com> (raw)
In-Reply-To: <4ED7BA0C.5060702@broadcom.com>
On 2011-12-01 18:31, Arend van Spriel wrote:
> On 12/01/2011 06:19 PM, Eric B Munson wrote:
>> On Thu, 01 Dec 2011, Jan Kiszka wrote:
>>
>>> On 2011-11-29 22:36, Eric B Munson wrote:
>>>> +
>>>> static void cpu_update_state(void *opaque, int running, RunState state)
>>>> {
>>>> CPUState *env = opaque;
>>>>
>>>> if (running) {
>>>> env->tsc_valid = false;
>>>> + kvm_put_guest_paused(env);
>>>
>>> checkpatch.pl would have asked you to remove this tab.
>>
>> Will change to spaces for V2.
>>
>
> Huh. Remove what tab? Indent are always 8-space TAB according
> CodingStyle doc:
>
> Chapter 1: Indentation
>
> Tabs are 8 characters, and thus indentations are also 8 characters.
> There are heretic movements that try to make indentations 4 (or even 2!)
> characters deep, and that is akin to trying to define the value of PI to
> be 3.
Don't worry, this is not kernel code. :) QEMU uses a different coding style.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: Eric B Munson <emunson@mgebm.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"ryanh@linux.vnet.ibm.com" <ryanh@linux.vnet.ibm.com>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [PATCH] Guest stop notification
Date: Thu, 01 Dec 2011 18:35:24 +0100 [thread overview]
Message-ID: <4ED7BADC.4070809@siemens.com> (raw)
In-Reply-To: <4ED7BA0C.5060702@broadcom.com>
On 2011-12-01 18:31, Arend van Spriel wrote:
> On 12/01/2011 06:19 PM, Eric B Munson wrote:
>> On Thu, 01 Dec 2011, Jan Kiszka wrote:
>>
>>> On 2011-11-29 22:36, Eric B Munson wrote:
>>>> +
>>>> static void cpu_update_state(void *opaque, int running, RunState state)
>>>> {
>>>> CPUState *env = opaque;
>>>>
>>>> if (running) {
>>>> env->tsc_valid = false;
>>>> + kvm_put_guest_paused(env);
>>>
>>> checkpatch.pl would have asked you to remove this tab.
>>
>> Will change to spaces for V2.
>>
>
> Huh. Remove what tab? Indent are always 8-space TAB according
> CodingStyle doc:
>
> Chapter 1: Indentation
>
> Tabs are 8 characters, and thus indentations are also 8 characters.
> There are heretic movements that try to make indentations 4 (or even 2!)
> characters deep, and that is akin to trying to define the value of PI to
> be 3.
Don't worry, this is not kernel code. :) QEMU uses a different coding style.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "ryanh@linux.vnet.ibm.com" <ryanh@linux.vnet.ibm.com>,
"aliguori@us.ibm.com" <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eric B Munson <emunson@mgebm.net>,
"avi@redhat.com" <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Guest stop notification
Date: Thu, 01 Dec 2011 18:35:24 +0100 [thread overview]
Message-ID: <4ED7BADC.4070809@siemens.com> (raw)
In-Reply-To: <4ED7BA0C.5060702@broadcom.com>
On 2011-12-01 18:31, Arend van Spriel wrote:
> On 12/01/2011 06:19 PM, Eric B Munson wrote:
>> On Thu, 01 Dec 2011, Jan Kiszka wrote:
>>
>>> On 2011-11-29 22:36, Eric B Munson wrote:
>>>> +
>>>> static void cpu_update_state(void *opaque, int running, RunState state)
>>>> {
>>>> CPUState *env = opaque;
>>>>
>>>> if (running) {
>>>> env->tsc_valid = false;
>>>> + kvm_put_guest_paused(env);
>>>
>>> checkpatch.pl would have asked you to remove this tab.
>>
>> Will change to spaces for V2.
>>
>
> Huh. Remove what tab? Indent are always 8-space TAB according
> CodingStyle doc:
>
> Chapter 1: Indentation
>
> Tabs are 8 characters, and thus indentations are also 8 characters.
> There are heretic movements that try to make indentations 4 (or even 2!)
> characters deep, and that is akin to trying to define the value of PI to
> be 3.
Don't worry, this is not kernel code. :) QEMU uses a different coding style.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-12-01 17:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 21:36 [PATCH] Guest stop notification Eric B Munson
2011-11-29 21:36 ` [Qemu-devel] " Eric B Munson
2011-11-29 21:36 ` Eric B Munson
2011-11-29 22:10 ` Anthony Liguori
2011-11-29 22:10 ` [Qemu-devel] " Anthony Liguori
2011-11-29 22:10 ` Anthony Liguori
2011-12-01 14:37 ` Jan Kiszka
2011-12-01 14:37 ` [Qemu-devel] " Jan Kiszka
2011-12-01 17:19 ` Eric B Munson
2011-12-01 17:19 ` [Qemu-devel] " Eric B Munson
2011-12-01 17:19 ` Eric B Munson
2011-12-01 17:31 ` Arend van Spriel
2011-12-01 17:31 ` [Qemu-devel] " Arend van Spriel
2011-12-01 17:35 ` Jan Kiszka [this message]
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 17:35 ` [Qemu-devel] " Jan Kiszka
2011-12-01 17:35 ` Jan Kiszka
2011-12-01 21:22 ` Marcelo Tosatti
2011-12-01 21:22 ` [Qemu-devel] " Marcelo Tosatti
2011-12-01 21:22 ` Marcelo Tosatti
2011-12-01 17:22 ` Eric B Munson
2011-12-01 17:22 ` [Qemu-devel] " Eric B Munson
2011-12-01 17:36 ` Jan Kiszka
2011-12-01 17:36 ` [Qemu-devel] " Jan Kiszka
2011-12-01 17:36 ` Jan Kiszka
2011-12-01 21:25 ` Marcelo Tosatti
2011-12-01 21:25 ` [Qemu-devel] " Marcelo Tosatti
2011-12-01 21:25 ` Marcelo Tosatti
2011-12-01 21:32 ` Eric B Munson
2011-12-01 21:32 ` [Qemu-devel] " Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED7BADC.4070809@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=aliguori@us.ibm.com \
--cc=arend@broadcom.com \
--cc=avi@redhat.com \
--cc=emunson@mgebm.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.